search for: __floatsidf

Hi, I recently came across the following in __floatsidf in compiler-rt: __floatsidf(int a) { ... if (a < 0) { ... a = -a; In the case where a == INT_MIN, is this negation not undefined behaviour? AIUI this function is used for software emulation on targets that have no hardware floating point suppor...

...4. /opt/Embedix/tools/arm-linux/bin/ld: Dwarf Error: Invalid or unhandled FORM value: 14. /opt/Embedix/tools/arm-linux/bin/ld: Dwarf Error: Could not find abbrev number 1032. /video/buildoutput/lib/libc.a(mktime.o): In function `__mktime_internal': mktime.o(.text+0x524): undefined reference to `__floatsidf' mktime.o(.text+0x534): undefined reference to `__floatsidf' mktime.o(.text+0x548): undefined reference to `__adddf3' mktime.o(.text+0x558): undefined reference to `__floatsidf' mktime.o(.text+0x56c): undefined reference to `__subdf3' mktime.o(.text+0x578): undefined reference t...

...-1))) compilerrt_abort(); The shift in this expression is done on a signed int (the literal "1") and I believe shifting into the sign bit like this is also UB. Where do you suggest we go from here? My intended approach is (1) propose a patch that avoids the signed negation in __floatsidf and __floatsisf as you suggested, (2) leave test__absv.i2 as-is as INT_MIN as an input is documented to be undefined, and (3) propose a patch that rephrases the left shifts in __absv.i2 to avoid UB there. I don't want to cause unnecessary headaches, so if there is a better way to go about thi...

On 26/10/15 02:54, Joerg Sonnenberger wrote: > On Sun, Oct 25, 2015 at 06:46:48AM -0400, Steve Canon via llvm-dev wrote: >> On Oct 24, 2015, at 6:02 PM, Chris Lattner <clattner at apple.com> wrote: >>> >>> >>>> On Oct 23, 2015, at 7:43 PM, Matthew Fernandez via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>>>> On 21/10/15 00:15,