search for: __dev_queue_xmit

...r 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst at redhat.com> wrote: > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > > > the following error. > > > > > > net ens4: Unexpected TXQ (0) queue failure: -28 > > > > > > This patch adds a check whether sq is full in XDP Xmit. > > > > > > Thanks. > > > > Acked-by: Michael S....

If the queue of xdp xmit is not an independent queue, then when the xdp xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter the following error. net ens4: Unexpected TXQ (0) queue failure: -28 This patch adds a check whether sq is full in XDP Xmit. Thanks. Xuan Zhuo (2): virtio_net: separate the logic of checking whether sq is full virtio_net: add checking sq is full inside xdp xmit drivers/net...

If the queue of xdp xmit is not an independent queue, then when the xdp xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter the following error. net ens4: Unexpected TXQ (0) queue failure: -28 This patch adds a check whether sq is full in XDP Xmit. Thanks. v1: 1. rename to check_sq_full_and_disable 2. reorder some funcs to avoid declaration Xuan Zhuo (3): virtio_net: reorder some funcs v...

...0x1aa/0x340) > [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] > [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 > [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 > [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec > [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c > [ 8.644134] [<000000000054b7c0>] ip_queue_xmit+0x170/0x3e8 > [ 8.644137] [<00000000005636ca>] tcp_transmit_skb+0x462/0x984 > [ 8.644140] [<0000000000564870>] tcp_write_x...

...0x1aa/0x340) > [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] > [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 > [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 > [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec > [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c > [ 8.644134] [<000000000054b7c0>] ip_queue_xmit+0x170/0x3e8 > [ 8.644137] [<00000000005636ca>] tcp_transmit_skb+0x462/0x984 > [ 8.644140] [<0000000000564870>] tcp_write_x...

...;> [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] >> [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 >> [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 >> [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec >> [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c >> [ 8.644134] [<000000000054b7c0>] ip_queue_xmit+0x170/0x3e8 >> [ 8.644137] [<00000000005636ca>] tcp_transmit_skb+0x462/0x984 >> [ 8.644140] [<0000000000564870&...

...? __skb_tx_hash+0x2f0/0x2f0 > > [ 310.035615] ? validate_xmit_skb_list+0xa3/0x100 > > [ 310.037782] sch_direct_xmit+0x2eb/0x7a0 > > [ 310.039842] ? dev_deactivate_queue.constprop.29+0x230/0x230 > > [ 310.041980] ? netdev_pick_tx+0x212/0x2b0 > > [ 310.043868] __dev_queue_xmit+0x12fa/0x20b0 > > [ 310.045564] ? netdev_pick_tx+0x2b0/0x2b0 > > [ 310.047210] ? __account_cfs_rq_runtime+0x630/0x630 > > [ 310.048301] ? update_stack_state+0x402/0x780 > > [ 310.049307] ? account_entity_enqueue+0x730/0x730 > > [ 310.050322] ? __rb_erase_colo...

...? __skb_tx_hash+0x2f0/0x2f0 > > [ 310.035615] ? validate_xmit_skb_list+0xa3/0x100 > > [ 310.037782] sch_direct_xmit+0x2eb/0x7a0 > > [ 310.039842] ? dev_deactivate_queue.constprop.29+0x230/0x230 > > [ 310.041980] ? netdev_pick_tx+0x212/0x2b0 > > [ 310.043868] __dev_queue_xmit+0x12fa/0x20b0 > > [ 310.045564] ? netdev_pick_tx+0x2b0/0x2b0 > > [ 310.047210] ? __account_cfs_rq_runtime+0x630/0x630 > > [ 310.048301] ? update_stack_state+0x402/0x780 > > [ 310.049307] ? account_entity_enqueue+0x730/0x730 > > [ 310.050322] ? __rb_erase_colo...

...irtqueue_add_outbuf+0x1aa/0x340) [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c [ 8.644134] [<000000000054b7c0>] ip_queue_xmit+0x170/0x3e8 [ 8.644137] [<00000000005636ca>] tcp_transmit_skb+0x462/0x984 [ 8.644140] [<0000000000564870>] tcp_write_xmit+0x220/0xd0c [...

...> > On Wed, 8 Mar 2023 14:59:36 +0800, Yunsheng Lin <linyunsheng at huawei.com> wrote: > >> On 2023/3/8 10:49, Xuan Zhuo wrote: > >>> If the queue of xdp xmit is not an independent queue, then when the xdp > >>> xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter > >>> the following error. > >>> > >>> net ens4: Unexpected TXQ (0) queue failure: -28 > >>> > >>> This patch adds a check whether sq is full in xdp xmit. > >>> > >>> Fixes: 56434a01b12e ("virti...

...0 Apr 02 14:20:59 helium kernel: warn_slowpath_null+0x1d/0x20 Apr 02 14:20:59 helium kernel: nft_meta_get_eval+0x40e/0x450 [nft_meta] Apr 02 14:20:59 helium kernel: nft_do_chain+0x102/0x4e0 [nf_tables] Apr 02 14:20:59 helium kernel: ? sch_direct_xmit+0x79/0x1b0 Apr 02 14:20:59 helium kernel: ? __dev_queue_xmit+0x227/0x630 Apr 02 14:20:59 helium kernel: ? ip6_finish_output2+0x229/0x510 Apr 02 14:20:59 helium kernel: ? find_next_bit+0x18/0x20 Apr 02 14:20:59 helium kernel: ? pcpu_alloc+0x2ce/0x630 Apr 02 14:20:59 helium kernel: ? ip6_finish_output+0xab/0x1c0 Apr 02 14:20:59 helium kernel: nft_do_chain...

This fixes virtio on Xen guests as well as on any other platform that uses virtio_pci on which physical addresses don't match bus addresses. This can be tested with: virtme-run --xen xen --kimg arch/x86/boot/bzImage --console using virtme from here: https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git Without these patches, the guest hangs forever. With these patches,

This fixes virtio on Xen guests as well as on any other platform that uses virtio_pci on which physical addresses don't match bus addresses. This can be tested with: virtme-run --xen xen --kimg arch/x86/boot/bzImage --console using virtme from here: https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git Without these patches, the guest hangs forever. With these patches,

...include/linux/netdevice.h:4042 [inline] netdev_start_xmit include/linux/netdevice.h:4051 [inline] xmit_one net/core/dev.c:2991 [inline] dev_hard_start_xmit+0x248/0xac0 net/core/dev.c:3007 sch_direct_xmit+0x31d/0x6d0 net/sched/sch_generic.c:187 __dev_xmit_skb net/core/dev.c:3189 [inline] __dev_queue_xmit+0x16f4/0x2070 net/core/dev.c:3456 dev_queue_xmit+0x17/0x20 net/core/dev.c:3521 neigh_hh_output include/net/neighbour.h:472 [inline] neigh_output include/net/neighbour.h:480 [inline] ip_finish_output2+0xece/0x1460 net/ipv4/ip_output.c:229 ip_finish_output+0x85e/0xd10 net/ipv4/ip_output.c:3...