search for: __dev_change_flags

...7065] __local_bh_enable_ip+0x1d9/0x250 [ 46.167076] virtnet_open+0x13c/0x440 [virtio_net] [ 46.167099] __dev_open+0x1cf/0x390 [ 46.167108] ? dev_set_rx_mode+0x30/0x30 [ 46.167113] ? __local_bh_enable_ip+0xf7/0x250 [ 46.167124] ? trace_hardirqs_on_caller+0x38d/0x6c0 [ 46.167130] ? __dev_change_flags+0x18d/0x630 [ 46.167142] __dev_change_flags+0x469/0x630 [ 46.167152] ? dev_set_allmulti+0x10/0x10 [ 46.167157] ? __lock_acquire+0x9c1/0x4b50 [ 46.167166] ? print_irqtrace_events+0x280/0x280 [ 46.167174] ? kvm_clock_read+0x1f/0x30 [ 46.167191] ? rtnetlink_put_metrics+0x530/0x530 [...

...7065] __local_bh_enable_ip+0x1d9/0x250 [ 46.167076] virtnet_open+0x13c/0x440 [virtio_net] [ 46.167099] __dev_open+0x1cf/0x390 [ 46.167108] ? dev_set_rx_mode+0x30/0x30 [ 46.167113] ? __local_bh_enable_ip+0xf7/0x250 [ 46.167124] ? trace_hardirqs_on_caller+0x38d/0x6c0 [ 46.167130] ? __dev_change_flags+0x18d/0x630 [ 46.167142] __dev_change_flags+0x469/0x630 [ 46.167152] ? dev_set_allmulti+0x10/0x10 [ 46.167157] ? __lock_acquire+0x9c1/0x4b50 [ 46.167166] ? print_irqtrace_events+0x280/0x280 [ 46.167174] ? kvm_clock_read+0x1f/0x30 [ 46.167191] ? rtnetlink_put_metrics+0x530/0x530 [...

...1d9/0x250 > [?? 46.167076]? virtnet_open+0x13c/0x440 [virtio_net] > [?? 46.167099]? __dev_open+0x1cf/0x390 > [?? 46.167108]? ? dev_set_rx_mode+0x30/0x30 > [?? 46.167113]? ? __local_bh_enable_ip+0xf7/0x250 > [?? 46.167124]? ? trace_hardirqs_on_caller+0x38d/0x6c0 > [?? 46.167130]? ? __dev_change_flags+0x18d/0x630 > [?? 46.167142]? __dev_change_flags+0x469/0x630 > [?? 46.167152]? ? dev_set_allmulti+0x10/0x10 > [?? 46.167157]? ? __lock_acquire+0x9c1/0x4b50 > [?? 46.167166]? ? print_irqtrace_events+0x280/0x280 > [?? 46.167174]? ? kvm_clock_read+0x1f/0x30 > [?? 46.167191]? ? rtnetl...

On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: > From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > > Add some ethtool stat items useful for performance analysis. > > Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> Series: Acked-by: Michael S. Tsirkin <mst at redhat.com> Patch 1 seems appropriate for stable, even

On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote: > From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> > > Add some ethtool stat items useful for performance analysis. > > Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> Series: Acked-by: Michael S. Tsirkin <mst at redhat.com> Patch 1 seems appropriate for stable, even

...off PHY and link layer > > if not IFF_UP > True, that's what I said about introducing internal state for those driver > and other kernel component. Very invasive change indeed. > > -Siwei Well I did say it's vague. How about hiding IFF_UP from dev_get_flags (and probably __dev_change_flags)?

...hat's what I said about introducing internal state for those driver > > > and other kernel component. Very invasive change indeed. > > > > > > -Siwei > > Well I did say it's vague. > > How about hiding IFF_UP from dev_get_flags (and probably > > __dev_change_flags)? > > > Any different? This has small footprint for the kernel change for sure, > while the discrepancy is still there. Anyone who writes code for IFF_UP will > not notice IFF_FAILOVER_SLAVE. > > Not to mention more userspace "fixup" work has to be done due to this...

...bc8 R15: 0000000000000001 FS: 00007f48b70e70c0(0000) GS:ffff88817bc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f48b6634950 CR3: 0000000277f1d002 CR4: 0000000000160eb0 Call Trace: virtnet_close+0x6a/0xb0 __dev_close_many+0x91/0x100 __dev_change_flags+0xc1/0x1c0 dev_change_flags+0x23/0x60 do_setlink+0x350/0xdf0 __rtnl_newlink+0x553/0x860 rtnl_newlink+0x43/0x60 rtnetlink_rcv_msg+0x289/0x340 netlink_rcv_skb+0xd1/0x110 netlink_unicast+0x203/0x310 netlink_sendmsg+0x32b/0x460 sock_sendmsg+0x5b/0x60 ____sys_sendmsg+0x23e/...

...bc8 R15: 0000000000000001 FS: 00007f48b70e70c0(0000) GS:ffff88817bc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f48b6634950 CR3: 0000000277f1d002 CR4: 0000000000160eb0 Call Trace: virtnet_close+0x6a/0xb0 __dev_close_many+0x91/0x100 __dev_change_flags+0xc1/0x1c0 dev_change_flags+0x23/0x60 do_setlink+0x350/0xdf0 __rtnl_newlink+0x553/0x860 rtnl_newlink+0x43/0x60 rtnetlink_rcv_msg+0x289/0x340 netlink_rcv_skb+0xd1/0x110 netlink_unicast+0x203/0x310 netlink_sendmsg+0x32b/0x460 sock_sendmsg+0x5b/0x60 ____sys_sendmsg+0x23e/...

...hose driver > > > > > and other kernel component. Very invasive change indeed. > > > > > > > > > > -Siwei > > > > Well I did say it's vague. > > > > How about hiding IFF_UP from dev_get_flags (and probably > > > > __dev_change_flags)? > > > > > > > Any different? This has small footprint for the kernel change for sure, > > > while the discrepancy is still there. Anyone who writes code for IFF_UP will > > > not notice IFF_FAILOVER_SLAVE. > > > > > > Not to mention more...

...iwl_mvm_up+0x89a/0xa60 [iwlmvm] [ 650.251303] __iwl_mvm_mac_start+0x26/0x1d0 [iwlmvm] [ 650.251306] iwl_mvm_mac_start+0x23/0x40 [iwlmvm] [ 650.251318] drv_start+0x43/0x100 [mac80211] [ 650.251327] ieee80211_do_open+0x251/0x900 [mac80211] [ 650.251330] __dev_open+0xcd/0x160 [ 650.251331] __dev_change_flags+0x1ad/0x220 [ 650.251332] dev_change_flags+0x21/0x60 [ 650.251333] do_setlink+0x314/0xe90 [ 650.251334] ? update_curr+0x70/0x1c0 [ 650.251335] ? cpumask_next_and+0x1a/0x20 [ 650.251337] ? __nla_validate_parse+0x51/0x840 [ 650.251338] ? cpumask_next+0x17/0x20 [ 650.251340] ? __snmp6_fi...

...nel component. Very invasive change indeed. > > > > > > > > > > > > > > -Siwei > > > > > > Well I did say it's vague. > > > > > > How about hiding IFF_UP from dev_get_flags (and probably > > > > > > __dev_change_flags)? > > > > > > > > > > > Any different? This has small footprint for the kernel change for sure, > > > > > while the discrepancy is still there. Anyone who writes code for IFF_UP will > > > > > not notice IFF_FAILOVER_SLAVE. > > &...

...: 00007f48b70e70c0(0000) GS:ffff88817bc00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f48b6634950 CR3: 0000000277f1d002 CR4: 0000000000160eb0 > Call Trace: > virtnet_close+0x6a/0xb0 > __dev_close_many+0x91/0x100 > __dev_change_flags+0xc1/0x1c0 > dev_change_flags+0x23/0x60 > do_setlink+0x350/0xdf0 > __rtnl_newlink+0x553/0x860 > rtnl_newlink+0x43/0x60 > rtnetlink_rcv_msg+0x289/0x340 > netlink_rcv_skb+0xd1/0x110 > netlink_unicast+0x203/0x310 > netlink_sendmsg+0x32b/0x460 > soc...

...ffffffff813015fd>] pci_disable_msi+0x3d/0x50 [ 321.354911] [<ffffffffa0040199>] bnx2_free_irq+0xa9/0xb0 [bnx2] [ 321.354920] [<ffffffffa0046bce>] bnx2_open+0x8e/0x210 [bnx2] [ 321.354929] [<ffffffff814b690e>] __dev_open+0x8e/0xe0 [ 321.354937] [<ffffffff814b5a56>] __dev_change_flags+0x96/0x170 [ 321.354944] [<ffffffff814b62e8>] dev_change_flags+0x28/0x70 [ 321.354953] [<ffffffff8151b5e7>] devinet_ioctl+0x5c7/0x710 [ 321.354961] [<ffffffff8151c863>] inet_ioctl+0x63/0x80 [ 321.354968] [<ffffffff814a27b2>] sock_do_ioctl+0x32/0x60 [ 321.354976] [&...

...818] do_softirq.part.18+0x6a/0x80 > [ 7.275825] __local_bh_enable_ip+0x49/0x50 > [ 7.275829] virtnet_open+0x129/0x440 > [ 7.275841] __dev_open+0x189/0x2c0 > [ 7.275848] ? dev_set_rx_mode+0x30/0x30 > [ 7.275857] ? do_raw_spin_unlock+0x54/0x220 > [ 7.275866] __dev_change_flags+0x3a9/0x4f0 > [ 7.275873] ? dev_set_allmulti+0x10/0x10 > [ 7.275889] dev_change_flags+0x7a/0x150 > [ 7.275900] do_setlink+0x9fe/0x2e40 > [ 7.275910] ? deref_stack_reg+0xad/0xe0 > [ 7.275917] ? __read_once_size_nocheck.constprop.6+0x10/0x10 > [ 7.275922] ? f...

...__local_bh_enable_ip+0x1ec/0x230 kernel/softirq.c:189 > local_bh_enable include/linux/bottom_half.h:32 [inline] > virtnet_napi_enable+0x8c/0xb0 drivers/net/virtio_net.c:1264 > virtnet_open+0x16d/0x4d0 drivers/net/virtio_net.c:1464 > __dev_open+0x26d/0x410 net/core/dev.c:1392 > __dev_change_flags+0x739/0x9c0 net/core/dev.c:7434 > dev_change_flags+0x89/0x150 net/core/dev.c:7503 > do_setlink+0xb16/0x3dd0 net/core/rtnetlink.c:2416 > rtnl_newlink+0x138d/0x1d60 net/core/rtnetlink.c:3029 > rtnetlink_rcv_msg+0x46e/0xc30 net/core/rtnetlink.c:4705 > netlink_rcv_skb+0x172/0x440 ne...

...__local_bh_enable_ip+0x1ec/0x230 kernel/softirq.c:189 > local_bh_enable include/linux/bottom_half.h:32 [inline] > virtnet_napi_enable+0x8c/0xb0 drivers/net/virtio_net.c:1264 > virtnet_open+0x16d/0x4d0 drivers/net/virtio_net.c:1464 > __dev_open+0x26d/0x410 net/core/dev.c:1392 > __dev_change_flags+0x739/0x9c0 net/core/dev.c:7434 > dev_change_flags+0x89/0x150 net/core/dev.c:7503 > do_setlink+0xb16/0x3dd0 net/core/rtnetlink.c:2416 > rtnl_newlink+0x138d/0x1d60 net/core/rtnetlink.c:3029 > rtnetlink_rcv_msg+0x46e/0xc30 net/core/rtnetlink.c:4705 > netlink_rcv_skb+0x172/0x440 ne...

...1ec/0x230 kernel/softirq.c:189 > > local_bh_enable include/linux/bottom_half.h:32 [inline] > > virtnet_napi_enable+0x8c/0xb0 drivers/net/virtio_net.c:1264 > > virtnet_open+0x16d/0x4d0 drivers/net/virtio_net.c:1464 > > __dev_open+0x26d/0x410 net/core/dev.c:1392 > > __dev_change_flags+0x739/0x9c0 net/core/dev.c:7434 > > dev_change_flags+0x89/0x150 net/core/dev.c:7503 > > do_setlink+0xb16/0x3dd0 net/core/rtnetlink.c:2416 > > rtnl_newlink+0x138d/0x1d60 net/core/rtnetlink.c:3029 > > rtnetlink_rcv_msg+0x46e/0xc30 net/core/rtnetlink.c:4705 > > netli...