search for: __block_write_begin

Changelog: v1--v2: 1. Re-order patches to avoid breaking compilation. Bean Huo (5): fs/buffer: clean up block_commit_write ext4: No need to check return value of block_commit_write() fs/ocfs2: No need to check return value of block_commit_write() udf: No need to check return value of block_commit_write() fs/buffer.c: convert block_commit_write to return void fs/buffer.c

...| 11 +++++------ > include/linux/buffer_head.h | 2 +- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index b88bb7ec38be..fa09cf94f771 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2116,7 +2116,7 @@ int __block_write_begin(struct page *page, loff_t pos, unsigned len, > } > EXPORT_SYMBOL(__block_write_begin); > > -int block_commit_write(struct page *page, unsigned int from, unsigned int to) > +void block_commit_write(struct page *page, unsigned int from, unsigned int to) > { > unsigned bloc...

*** BLURB HERE *** Bean Huo (5): fs/buffer: clean up block_commit_write fs/buffer.c: convert block_commit_write to return void ext4: No need to check return value of block_commit_write() fs/ocfs2: No need to check return value of block_commit_write() udf: No need to check return value of block_commit_write() fs/buffer.c | 24 +++++++-----------------

...7 ++----- fs/ocfs2/file.c | 7 +------ fs/udf/file.c | 6 +++--- include/linux/buffer_head.h | 2 +- 5 files changed, 13 insertions(+), 23 deletions(-) --- a/fs/buffer.c~fs-convert-block_commit_write-to-return-void +++ a/fs/buffer.c @@ -2180,7 +2180,7 @@ int __block_write_begin(struct page *pag } EXPORT_SYMBOL(__block_write_begin); -static int __block_commit_write(struct folio *folio, size_t from, size_t to) +static void __block_commit_write(struct folio *folio, size_t from, size_t to) { size_t block_start, block_end; bool partial = false; @@ -2215,7 +2215,6 @@ s...

...e.cz> Honza > --- > fs/buffer.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index a7fc561758b1..b88bb7ec38be 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2116,8 +2116,7 @@ int __block_write_begin(struct page *page, loff_t pos, unsigned len, > } > EXPORT_SYMBOL(__block_write_begin); > > -static int __block_commit_write(struct inode *inode, struct page *page, > - unsigned from, unsigned to) > +int block_commit_write(struct page *page, unsigned int from, unsigned int to)...

...Cc: Theodore Ts'o <tytso at mit.edu> Signed-off-by: Andrew Morton <akpm at linux-foundation.org> --- fs/buffer.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) --- a/fs/buffer.c~fs-buffer-clean-up-block_commit_write +++ a/fs/buffer.c @@ -2180,8 +2180,7 @@ int __block_write_begin(struct page *pag } EXPORT_SYMBOL(__block_write_begin); -static int __block_commit_write(struct inode *inode, struct folio *folio, - size_t from, size_t to) +static int __block_commit_write(struct folio *folio, size_t from, size_t to) { size_t block_start, block_end; bool partial = false;...

...? kmem_cache_alloc+0x1c2/0x1f0 [ 1085.194006] [<ffffffffa96787b1>] ? alloc_buffer_head+0x21/0x60 [ 1085.194018] [<ffffffffc1be035f>] _ext4_get_block+0x1df/0x220 [ext4] [ 1085.194030] [<ffffffffc1be03b6>] ext4_get_block+0x16/0x20 [ext4] [ 1085.194036] [<ffffffffa967ae78>] __block_write_begin_int+0x198/0x5f0 [ 1085.194041] [<ffffffffa961c0b2>] ? kmem_cache_alloc+0x1c2/0x1f0 [ 1085.194053] [<ffffffffc1be03a0>] ? _ext4_get_block+0x220/0x220 [ext4] [ 1085.194067] [<ffffffffc1be4c56>] ? ext4_write_begin+0x116/0x440 [ext4] [ 1085.194073] [<ffffffffa967b2e1>] __blo...

...+), 3 deletions(-) > > diff --git a/fs/udf/file.c b/fs/udf/file.c > index 8238f742377b..b1a062922a24 100644 > --- a/fs/udf/file.c > +++ b/fs/udf/file.c > @@ -67,13 +67,13 @@ static vm_fault_t udf_page_mkwrite(struct vm_fault *vmf) > else > end = PAGE_SIZE; > err = __block_write_begin(page, 0, end, udf_get_block); > - if (!err) > - err = block_commit_write(page, 0, end); > - if (err < 0) { > + if (err) { > unlock_page(page); > ret = block_page_mkwrite_return(err); > goto out_unlock; > } > + > + block_commit_write(page, 0, end); >...