search for: 9e88d6b

...sserting that read_cb_valid and completion_cb_valid are 0 (if we are confident in our ability to strand the command unretired due to use of a filter delay)? > + > + exit (EXIT_SUCCESS); > +} > diff --git a/tests/meta-base-allocation.c b/tests/meta-base-allocation.c > index 95e029b..9e88d6b 100644 > --- a/tests/meta-base-allocation.c Most of my comments can be addressed by followups or pertain to the new test; I'm okay if you want to push this without posting v4. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | li...

I think I've addressed everything that was raised in review. Some of the highlights: - Callbacks should be freed reliably along all exit paths. - There's a simple test of closure lifetimes. - I've tried to use VALID|FREE in all the places where I'm confident that it's safe and correct to do. There may be more places. Note this is an optimization and shouldn't

...k_fn) (void *user_data, int64_t cookie, int *error); +typedef int (*callback_fn) (unsigned valid_flag, void *user_data, + int64_t cookie, int *error); struct command_cb { union { diff --git a/tests/meta-base-allocation.c b/tests/meta-base-allocation.c index 95e029b..9e88d6b 100644 --- a/tests/meta-base-allocation.c +++ b/tests/meta-base-allocation.c @@ -30,7 +30,8 @@ #include <libnbd.h> -static int check_extent (void *data, const char *metacontext, +static int check_extent (unsigned valid_flag, void *data, + const char *metacontext,...

...read_cb, NULL, + completion_cb, NULL, 0); + nbd_close (nbd); + + assert (read_cb_free == 1); + assert (completion_cb_free == 1); + + exit (EXIT_SUCCESS); +} diff --git a/tests/meta-base-allocation.c b/tests/meta-base-allocation.c index 95e029b..9e88d6b 100644 --- a/tests/meta-base-allocation.c +++ b/tests/meta-base-allocation.c @@ -30,7 +30,8 @@ #include <libnbd.h> -static int check_extent (void *data, const char *metacontext, +static int check_extent (unsigned valid_flag, void *data, + const char *metacontext,...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-July/thread.html#00231 The changes address everything that Eric picked up in his review of the first two patches. I have also added two more patches (4 and 5) which respectively fix docs and change int status -> unsigned status, as discussed. Passes make, check, check-valgrind. Rich.