Displaying 2 results from an estimated 2 matches for "9c8fccdf".
2019 Aug 14
2
[libnbd PATCH] lib: Consolidate free callbacks to just happen at retire time
...early free, so that the later check during retirement didn't free
again.
But now that our .free callback is distinct from our other callbacks,
there is no longer an advantage to bundling things, and a significant
reduction in lines of code by just doing it in one place. This
basically reverts 9c8fccdf (which had slightly-questionable C
type-punning anyway) and 57150880.
---
lib/internal.h | 14 --------------
generator/states-reply-simple.c | 1 -
generator/states-reply-structured.c | 20 +-------------------
generator/states-reply.c | 1 -
generator/states...
2019 Aug 15
0
Re: [libnbd PATCH] lib: Consolidate free callbacks to just happen at retire time
...check during retirement didn't free
> again.
>
> But now that our .free callback is distinct from our other callbacks,
> there is no longer an advantage to bundling things, and a significant
> reduction in lines of code by just doing it in one place. This
> basically reverts 9c8fccdf (which had slightly-questionable C
> type-punning anyway) and 57150880.
I didn't see this one before implementing an alternate version here:
https://www.redhat.com/archives/libguestfs/2019-August/msg00251.html
https://www.redhat.com/archives/libguestfs/2019-August/msg00253.html
They'r...