search for: 9564e138b1f6

...used uninitialized in this function [-Werror=uninitialized] This seems absolutely right, so we should add an extra check to prevent copying uninitialized stack data into the statistics. >From all I can tell, this has been broken since the statistics code was originally added in 2.6.34. Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") Signed-off-by: Arnd Bergmann <arnd at arndb.de> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4...

...used uninitialized in this function [-Werror=uninitialized] This seems absolutely right, so we should add an extra check to prevent copying uninitialized stack data into the statistics. >From all I can tell, this has been broken since the statistics code was originally added in 2.6.34. Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") Signed-off-by: Arnd Bergmann <arnd at arndb.de> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4...

Ensure that elements of the array that correspond to unavailable features are set to NULL; previously, they would be left uninitialized. Since the corresponding names array elements were explicitly set to NULL, the uninitialized callback pointers would not actually be dereferenced; however, the uninitialized callbacks elements would still be read in vp_find_vqs_msix() and used to calculate the

Ensure that elements of the array that correspond to unavailable features are set to NULL; previously, they would be left uninitialized. Since the corresponding names array elements were explicitly set to NULL, the uninitialized callback pointers would not actually be dereferenced; however, the uninitialized callbacks elements would still be read in vp_find_vqs_msix() and used to calculate the

...ed] >> >> This seems absolutely right, so we should add an extra check to >> prevent copying uninitialized stack data into the statistics. >> From all I can tell, this has been broken since the statistics code >> was originally added in 2.6.34. >> >> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") >> Signed-off-by: Arnd Bergmann <arnd at arndb.de> >> --- >> drivers/virtio/virtio_balloon.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/virtio/virti...

...ed] >> >> This seems absolutely right, so we should add an extra check to >> prevent copying uninitialized stack data into the statistics. >> From all I can tell, this has been broken since the statistics code >> was originally added in 2.6.34. >> >> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") >> Signed-off-by: Arnd Bergmann <arnd at arndb.de> >> --- >> drivers/virtio/virtio_balloon.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/virtio/virti...

...ight, so we should add an extra check to > >>> prevent copying uninitialized stack data into the statistics. > >>> From all I can tell, this has been broken since the statistics code > >>> was originally added in 2.6.34. > >>> > >>> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > >>> Signed-off-by: Arnd Bergmann <arnd at arndb.de> > >>> --- > >>> drivers/virtio/virtio_balloon.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>&g...

...ight, so we should add an extra check to > >>> prevent copying uninitialized stack data into the statistics. > >>> From all I can tell, this has been broken since the statistics code > >>> was originally added in 2.6.34. > >>> > >>> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > >>> Signed-off-by: Arnd Bergmann <arnd at arndb.de> > >>> --- > >>> drivers/virtio/virtio_balloon.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>&g...

...>> >>> prevent copying uninitialized stack data into the statistics. > >> >>> From all I can tell, this has been broken since the statistics code > >> >>> was originally added in 2.6.34. > >> >>> > >> >>> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > >> >>> Signed-off-by: Arnd Bergmann <arnd at arndb.de> > >> >>> --- > >> >>> drivers/virtio/virtio_balloon.c | 2 ++ > >> >>> 1 file chan...

...>> >>> prevent copying uninitialized stack data into the statistics. > >> >>> From all I can tell, this has been broken since the statistics code > >> >>> was originally added in 2.6.34. > >> >>> > >> >>> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > >> >>> Signed-off-by: Arnd Bergmann <arnd at arndb.de> > >> >>> --- > >> >>> drivers/virtio/virtio_balloon.c | 2 ++ > >> >>> 1 file chan...

...ction [-Werror=uninitialized] > > This seems absolutely right, so we should add an extra check to > prevent copying uninitialized stack data into the statistics. > From all I can tell, this has been broken since the statistics code > was originally added in 2.6.34. > > Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > Signed-off-by: Arnd Bergmann <arnd at arndb.de> > --- > drivers/virtio/virtio_balloon.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/v...

...used uninitialized in this function [-Werror=uninitialized] This seems absolutely right, so we should add an extra check to prevent copying uninitialized stack data into the statistics. >From all I can tell, this has been broken since the statistics code was originally added in 2.6.34. Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") Signed-off-by: Arnd Bergmann <arnd at arndb.de> Signed-off-by: Ladi Prosek <lprosek at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> [arnd: backported to 4.4] Signed-off-by: Arnd B...

...MSI-X > vectors required. > > Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") > Signed-off-by: Daniel Verkamp <dverkamp at chromium.org> Actually, we already have the issue with the stats VQ, no? So I think this one is more appropriate: Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") > --- > drivers/virtio/virtio_balloon.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 93f995f6cf36..8e400ece9...

...; This seems absolutely right, so we should add an extra check to >>> prevent copying uninitialized stack data into the statistics. >>> From all I can tell, this has been broken since the statistics code >>> was originally added in 2.6.34. >>> >>> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") >>> Signed-off-by: Arnd Bergmann <arnd at arndb.de> >>> --- >>> drivers/virtio/virtio_balloon.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --gi...

...dd an extra check to >> >>> prevent copying uninitialized stack data into the statistics. >> >>> From all I can tell, this has been broken since the statistics code >> >>> was originally added in 2.6.34. >> >>> >> >>> Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)") >> >>> Signed-off-by: Arnd Bergmann <arnd at arndb.de> >> >>> --- >> >>> drivers/virtio/virtio_balloon.c | 2 ++ >> >>> 1 file changed, 2 insertions(+)...

This series fixes issues with variable initialization in the virtio balloon driver which manifest as the driver sending invalid memory stats to the host. v1->v2: * Call update_balloon_stats instead of filling the buffer with invalid tags. * Add BUG_ON to update_balloon_stats to formalize the invariant that all slots in the buffer must be initialized. v2->v3: * Remove BUG_ON and

This series fixes issues with variable initialization in the virtio balloon driver which manifest as the driver sending invalid memory stats to the host. v1->v2: * Call update_balloon_stats instead of filling the buffer with invalid tags. * Add BUG_ON to update_balloon_stats to formalize the invariant that all slots in the buffer must be initialized. v2->v3: * Remove BUG_ON and