search for: 91746e0

From: "Richard W.M. Jones" <rjones at redhat.com> In Linux, close (fd) closes the file descriptor even if it returns an error. --- daemon/file.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index e0f8794..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -483,7 +483,6 @@ pread_fd (int fd, int count, int64_t offset, size_t *size_r, if (close (fd) == -1) { reply_with_perror ("close: %s", display_path); - close (fd); free (buf); return NULL; } @@ -539,7 +538,6 @@ pwr...

This is a possibly better work-around for bug 769304, the bug where blkid runs from udev whenever a device closes, causing the subsequent operation to fail. For background to this change, see: https://rwmj.wordpress.com/2012/01/19/udev-unexpectedness/#content So far we have noticed this problem in two places (although I'm fairly certain it affects many more): - in virt-resize, after

...chard W.M. Jones" <rjones at redhat.com> This reverts commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11. --- daemon/file.c | 18 +++--------------- daemon/parted.c | 3 +-- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index 057e15d..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -525,7 +525,7 @@ do_pread_device (const char *device, int count, int64_t offset, size_t *size_r) static int pwrite_fd (int fd, const char *content, size_t size, int64_t offset, - const char *display_path, int settle) + const...