search for: 90,17

...closures was > wasteful as we needed to register a "close callback" to free the > closure when the handle is closed. But if you had submitted thousands > of asynchronous commands you would end up registering thousands of > close callbacks. > > +++ b/lib/aio.c > @@ -90,6 +90,17 @@ nbd_unlocked_aio_command_completed (struct nbd_handle *h, > else > h->cmds_done = cmd->next; > > + /* Free the callbacks. */ > + if (cmd->type != NBD_CMD_READ && cmd->cb.fn.extent) > + cmd->cb.fn.extent (LIBNBD_CALLBACK_FREE, cmd-&...

...ial_csum_set(skb, start, off)) return -EINVAL; - if (skb_transport_offset(skb) + thlen > skb_headlen(skb)) + p_off = skb_transport_offset(skb) + thlen; + if (p_off > skb_headlen(skb)) return -EINVAL; } else { /* gso packets without NEEDS_CSUM do not set transport_offset. @@ -90,17 +92,25 @@ static inline int virtio_net_hdr_to_skb(struct sk_buff *skb, return -EINVAL; } - if (keys.control.thoff + thlen > skb_headlen(skb) || + p_off = keys.control.thoff + thlen; + if (p_off > skb_headlen(skb) || keys.basic.ip_proto != ip_proto) return -EIN...

...in libao-0.8.2-new/src/plugins/alsa09: Makefile diff -ur libao-0.8.2/src/plugins/alsa09/ao_alsa09.c libao-0.8.2-new/src/plugins/alsa09/ao_alsa09.c --- libao-0.8.2/src/plugins/alsa09/ao_alsa09.c Tue Dec 18 17:39:24 2001 +++ libao-0.8.2-new/src/plugins/alsa09/ao_alsa09.c Sat Apr 20 21:41:39 2002 @@ -90,17 +90,33 @@ return &ao_alsa_info; } +static int get_alsa_environment_buf_size(void) +{ + char * buf; + + buf = getenv("AO_ALSA_BUFFER_SIZE"); + if (buf == NULL) + return 0; + else + return strtol(buf, NULL, 10); +} int ao_plugin_device_init(ao_device *device) { ao_als...

..._dp_mst_topology_mgr *mgr = + container_of(work, struct drm_dp_mst_topology_mgr, work); + struct drm_device *dev = mgr->dev; struct drm_dp_mst_branch *mstb; int ret; + mutex_lock(&mgr->probe_lock); + mutex_lock(&mgr->lock); mstb = mgr->mst_primary; if (mstb) { @@ -2190,6 +2193,7 @@ static void drm_dp_mst_link_probe_work(struct work_struct *work) drm_dp_check_and_send_link_address(mgr, mstb); drm_dp_mst_topology_put_mstb(mstb); } + mutex_unlock(&mgr->probe_lock); } static bool drm_dp_validate_guid(struct drm_dp_mst_topology_mgr *mgr, @@ -3313,6...

...7,7 @@ XB-Python-Version: ${python:Versions} Package: xen-ioemu-3.0.4-1 -Architecture: amd64 i386 +Architecture: amd64 i386 ia64 Depends: ${shlibs:Depends}, xen-utils-3.0.4-1 Description: XEN administrative tools The userspace tools to manage a system virtualized through the XEN virtual @@ -90,3 +90,17 @@ kernel specifically crafted to work as the Domain 0, mediating hardware access for XEN itself. +Package: xen-hypervisor-3.0.4-1-ia64 +Architecture: ia64 +Provides: xen-hypervisor, xen-hypervisor-3.0, xen-hypervisor-3.0.4-1, xen-hypervisor-ia64 +Depends: xen-utils-3.0.4-1 +Suggests...

...t;cb.callback (cmd->cb.user_data, cmd->cookie, > + if (cmd->cb.callback (LIBNBD_CALLBACK_VALID, > + cmd->cb.user_data, cmd->cookie, [1] another spot where we only call things once, and so we could pass VALID|FREE. > +++ b/lib/aio.c > @@ -90,6 +90,17 @@ nbd_unlocked_aio_command_completed (struct nbd_handle *h, > else > h->cmds_done = cmd->next; > > + /* Free the callbacks. */ > + if (cmd->type != NBD_CMD_READ && cmd->cb.fn.extent) > + cmd->cb.fn.extent (LIBNBD_CALLBACK_FREE, cmd-&...

..."\n"; pr "{\n"; + pr " if (valid_flag & LIBNBD_CALLBACK_VALID) {\n"; pr " int ret;\n"; pr " PyGILState_STATE py_save = PyGILState_UNLOCKED;\n"; pr " PyObject *py_args, *py_ret;\n"; @@ -3927,6 +3907,12 @@ let print_python_binding name { args; ret } = | UInt _ | UInt32 _ -> assert false ) cbargs; pr " return ret;\n"; + pr " }\n"; + pr "\n"; + pr " if (valid_flag & LIBNBD_CALLBACK_FREE)\n"; +...

...NULL); if (r == -1) { reply_with_error ("%s: %s", device, err); @@ -59,6 +61,8 @@ do_scrub_file (const char *file) char *err; int r; + IF_NOT_AVAILABLE_ERROR (scrub, -1); + /* Make the path relative to /sysroot. */ buf = sysroot_path (file); if (!buf) { @@ -86,6 +90,8 @@ do_scrub_freespace (const char *dir) char *err; int r; + IF_NOT_AVAILABLE_ERROR (scrub, -1); + /* Make the path relative to /sysroot. */ buf = sysroot_path (dir); if (!buf) { diff --git a/daemon/selinux.c b/daemon/selinux.c index 2db05ee..9c52781 100644 --- a/daemon/selinux.c...

...ue\");\n" n n; + pr " *%s = PyLong_AsLong (py_%s_ret);\n" n n; + pr " Py_DECREF (py_%s_ret);\n" n; + pr " Py_DECREF (py_%s);\n" n | BytesIn _ | Int _ | Int64 _ | String _ @@ -3926,6 +3906,11 @@ let print_python_binding name { args; ret } = | Path _ | SockAddrAndLen _ | StringList _ | UInt _ | UInt32 _ -> assert false ) cbargs; + pr " }\n"; + pr "\n"; + pr " if (valid_flag & LIBNBD_CALLBACK_FREE)\n...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-July/thread.html#00231 The changes address everything that Eric picked up in his review of the first two patches. I have also added two more patches (4 and 5) which respectively fix docs and change int status -> unsigned status, as discussed. Passes make, check, check-valgrind. Rich.

This implements most of what I wrote here: https://www.redhat.com/archives/libguestfs/2019-July/msg00213.html

...@@ sources = \ ruby.ml \ structs.ml \ structs.mli \ + tests.ml \ + tests_mk.ml \ + test_harness.ml \ tests_c_api.ml \ types.ml \ utils.ml \ @@ -68,6 +71,8 @@ objects = \ pr.cmo \ docstrings.cmo \ checks.cmo \ + tests.cmo \ + tests_mk.cmo \ c.cmo \ xdr.cmo \ daemon.cmo \ @@ -90,17 +95,30 @@ objects = \ customize.cmo \ main.cmo +test_harness_objects = \ + types.cmo \ + utils.cmo \ + tests.cmo \ + test_harness.cmo + EXTRA_DIST = $(sources) files-generated.txt OCAMLCFLAGS = $(OCAML_WARN_ERROR) -I $(srcdir) -I . -package unix,str noinst_PROGRAM = generator +# I...

This is the final portion of the large series for adding MST suspend/resume reprobing that I've been working on for quite a while now. In addition, I: * Refactored and cleaned up any code I ended up digging through in the process of understanding how some parts of these helpers worked. * Added some debugging tools along the way that I ended up needing to figure out some issues in my own

Hi Dan, Jérôme and Jason, below is a series that cleans up the dev_pagemap interface so that it is more easily usable, which removes the need to wrap it in hmm and thus allowing to kill a lot of code Note: this series is on top of the rdma/hmm branch + the dev_pagemap releas fix series from Dan that went into 5.2-rc5. Git tree: git://git.infradead.org/users/hch/misc.git

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The

Since v3: - A large number of fixes, especially for running the tests on installed libguestfs. - Fixed EXTRA_DIST rules throughout. - Extra patch 17/17 which is a tidy-up of the generated XML listing guests. Rich.

This is a more complete patch to add the test harness. The only parts missing now are the language bindings (except OCaml). The language bindings need a bit more thought. At the moment most language binding tests are done through some sort of shell script like perl/run-perl-tests which either runs each test itself or uses some language-specific machinary to run each test. The problem with that

Since v2: - Add perl tests. - Reworked and fixed the tests for virt-builder. - Some further minor bug fixes.