search for: 893,7

...hp.com> Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net: Add a MAC filter table Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct sg_init_one(&hdr, &ctrl, sizeof(ctrl)); sgs[out_num++] = &hdr; - if (out) + for (; out; out = sg_next(out)) sgs[out_num++] = out; if (in) sgs[out_num + in_num++] = in;

...hp.com> Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net: Add a MAC filter table Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct sg_init_one(&hdr, &ctrl, sizeof(ctrl)); sgs[out_num++] = &hdr; - if (out) + for (; out; out = sg_next(out)) sgs[out_num++] = out; if (in) sgs[out_num + in_num++] = in;

...m> Question is, can we detect a broken driver in the host somehow? If not we'll need a feature bit for hosts to actually do MC filtering. > --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 > +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 > @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct > sg_init_one(&hdr, &ctrl, sizeof(ctrl)); > sgs[out_num++] = &hdr; > > - if (out) > + for (; out; out = sg_next(out)) > sgs[out_num++] = out; > if (in) > sgs[out_num + in_num++] = in;

...ly) status = SSH2_FX_PERMISSION_DENIED; else { - if (lseek(fd, off, SEEK_SET) < 0) { + if (!(handle_to_flags(handle) & O_APPEND) && + lseek(fd, off, SEEK_SET) < 0) { status = errno_to_portable(errno); error("process_write: seek failed"); } else { @@ -893,7 +908,7 @@ process_opendir(void) if (dirp == NULL) { status = errno_to_portable(errno); } else { - handle = handle_new(HANDLE_DIR, path, 0, dirp); + handle = handle_new(HANDLE_DIR, path, 0, 0, dirp); if (handle < 0) { closedir(dirp); } else {

...buff *skb) /* Even if we can, don't push here yet as this would skew * csum_start offset below. */ if (can_push) - hdr = (struct skb_vnet_hdr *)(skb->data - hdr_len); + hdr = (struct virtio_net_hdr_mrg_rxbuf *)(skb->data - hdr_len); else hdr = skb_vnet_hdr(skb); @@ -902,7 +893,7 @@ static int xmit_skb(struct send_queue *sq, struct sk_buff *skb) } if (vi->mergeable_rx_bufs) - hdr->mhdr.num_buffers = 0; + hdr->num_buffers = 0; sg_init_table(sq->sg, MAX_SKB_FRAGS + 2); if (can_push) { @@ -1773,18 +1764,19 @@ static int virtnet_probe(struct virtio_d...

...buff *skb) /* Even if we can, don't push here yet as this would skew * csum_start offset below. */ if (can_push) - hdr = (struct skb_vnet_hdr *)(skb->data - hdr_len); + hdr = (struct virtio_net_hdr_mrg_rxbuf *)(skb->data - hdr_len); else hdr = skb_vnet_hdr(skb); @@ -902,7 +893,7 @@ static int xmit_skb(struct send_queue *sq, struct sk_buff *skb) } if (vi->mergeable_rx_bufs) - hdr->mhdr.num_buffers = 0; + hdr->num_buffers = 0; sg_init_table(sq->sg, MAX_SKB_FRAGS + 2); if (can_push) { @@ -1773,18 +1764,19 @@ static int virtnet_probe(struct virtio_d...

Too many places poke at [rs]q->vq->vdev->priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/net/virtio_net.c

Too many places poke at [rs]q->vq->vdev->priv just to get the the vi structure. Let's just pass the pointer around: seems cleaner, and might even be faster. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/net/virtio_net.c

Changes in v11 - Drop change log histroy in commit log Changes in v10 - Drop comments about lun - Add Enable VIRTIO_SCSI_F_HOTPLUG to this series Changes in v9 - Drop tcm_vhost_check_feature - Add Refactor the lock nesting rule to this sereis Asias He (4): tcm_vhost: Refactor the lock nesting rule tcm_vhost: Add hotplug/hotunplug support tcm_vhost: Add ioctl to get and set events missed

Changes in v11 - Drop change log histroy in commit log Changes in v10 - Drop comments about lun - Add Enable VIRTIO_SCSI_F_HOTPLUG to this series Changes in v9 - Drop tcm_vhost_check_feature - Add Refactor the lock nesting rule to this sereis Asias He (4): tcm_vhost: Refactor the lock nesting rule tcm_vhost: Add hotplug/hotunplug support tcm_vhost: Add ioctl to get and set events missed

...- && st->st_gid != file->gid) + if (preserve_gid && file->gid != GID_NONE && st->st_gid != file->gid + && !(S_ISDIR(st->st_mode) && omit_dir_changes)) iflags |= ITEM_REPORT_GROUP; } else iflags |= ITEM_IS_NEW; @@ -891,7 +893,7 @@ /* If we're not preserving permissions, change the file-list's * mode based on the local permissions and some heuristics. */ - if (!preserve_perms) { + if (!preserve_perms || (S_ISDIR(st.st_mode) && omit_dir_changes)) { int exists = statret == 0 && S_ISD...

...>vdev.driver_ok = virtio_net_driver_ok; n->rx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_rx); n->tx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_tx); n->ctrl_vq = virtio_add_queue(&n->vdev, 64, virtio_net_handle_ctrl); @@ -864,6 +893,7 @@ VirtIODevice *virtio_net_init(DeviceState *dev) n->vdev.nvectors = 3; else n->vdev.nvectors = dev->nd->nvectors; + n->vhost_device = dev->nd->vhost_device; register_savevm("virtio-net", virtio_net_id++, VIRTIO_NET_VM_VERSION,...

...>vdev.driver_ok = virtio_net_driver_ok; n->rx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_rx); n->tx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_tx); n->ctrl_vq = virtio_add_queue(&n->vdev, 64, virtio_net_handle_ctrl); @@ -864,6 +893,7 @@ VirtIODevice *virtio_net_init(DeviceState *dev) n->vdev.nvectors = 3; else n->vdev.nvectors = dev->nd->nvectors; + n->vhost_device = dev->nd->vhost_device; register_savevm("virtio-net", virtio_net_id++, VIRTIO_NET_VM_VERSION,...

..._flg) = 0x8; - WSET(buf, smb_flg2, 0x3); + if (server->opt.protocol > SMB_PROTOCOL_CORE) + { + *(buf+smb_flg) = 0x8; + WSET(buf, smb_flg2, 0x3); + } *p++ = wct; /* wct */ p += 2 * wct; WSET(p, 0, bcc); @@ -893,7 +919,9 @@ * If the file is open with write permissions, * update the time stamps to sync mtime and atime. */ - if (ino->u.smbfs_i.access != SMB_O_RDONLY) { + if ((server->opt.protocol >= SMB_PROTOCOL_LANMAN2)...

...ls to the virtual function completely. </ins><span class="cx"> </span><span class="cx"> See also: "sort_children":#TreeCtrl_sortchildren </span><span class="cx"> </span><span class="lines">@@ -834,7 +893,7 @@ </span><span class="cx"> </span><span class="cx"> h3(#TreeCtrl_selectitem). TreeCtrl#select_item </span><span class="cx"> </span><del>- Boolean *select_item*(%(arg-type)TreeItemId% item, %(arg-type)Boolean% select...

Inline George > On Jan 26, 2015, at 1:05 PM, Daniel Berlin <dberlin at dberlin.org> wrote: > > George, given that, can you just build constexpr handling (it's not as easy as you think) as a separate funciton and have it use it in the right places? Will do. :) > FWIW, my current list of CFLAA issues is: > > 1. Unknown values (results from ptrtoint, incoming

So we don't ever have to worry about drivers touching drm_dp_mst_port structs without verifying them and crashing again. Lyude Paul (6): drm/dp_mst: Add drm_dp_get_payload_info() drm/nouveau: Use drm_dp_get_payload_info() for getting payload/vcpi drm/nouveau: Stop reading port->mgr in nv50_mstc_get_modes() drm/nouveau: Stop reading port->mgr in nv50_mstc_detect() drm/dp_mst:

...orwards[i].host_port); } +#endif } static void @@ -868,6 +872,7 @@ struct winsize ws; char *cp; +#ifdef WITH_COMPRESSION /* Enable compression if requested. */ if (options.compression) { debug("Requesting compression at level %d.", options.compression_level); @@ -888,6 +893,7 @@ else packet_disconnect("Protocol error waiting for compression response."); } +#endif /* Allocate a pseudo tty if appropriate. */ if (tty_flag) { debug("Requesting pty."); @@ -927,6 +933,7 @@ else packet_disconnect("Protocol error waiting for pty...

George, given that, can you just build constexpr handling (it's not as easy as you think) as a separate funciton and have it use it in the right places? FWIW, my current list of CFLAA issues is: 1. Unknown values (results from ptrtoint, incoming pointers, etc) are not treated as unknown. These should be done through graph edge (so that they can be one way, otherwise, you will unify

...fdec/swfdec_as_interpret.c @@ -876,6 +876,7 @@ swfdec_action_call_method (SwfdecAsContext *cx, guint action, const guint8 *data SwfdecAsFrame *frame = cx->frame; SwfdecAsValue *val; SwfdecAsObject *obj; + SwfdecAsObject *pobj = NULL; guint n_args; const char *name; @@ -892,7 +893,7 @@ swfdec_action_call_method (SwfdecAsContext *cx, guint action, const guint8 *data name = ""; } else { SWFDEC_AS_VALUE_SET_OBJECT (swfdec_as_stack_peek (cx, 3), obj); - swfdec_as_object_get_variable (obj, name, swfdec_as_stack_peek (cx, 2)); + swfdec_as_obj...