search for: 871d658c9ceb

...have ownership or expertise in, please sign up for fixing the tests by Monday, Nov. 9. Otherwise, I will "blanket-add" --allow-unused-prefixes=true to the remaining failing tests. On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> wrote: > An update: as of 871d658c9ceb, the flag is now available, if folks need to > use it. > > On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> wrote: > >> Hello all, >> >> TL;DR; if you used FileCheck --check-prefixes and you missed (misspelled, >> for instance) one of...

...t unused prefixes are used > intentionally" or the like. > Ack. or, we can grep for -allow-unused-prefixes=true, wdyt? > > >> >> >> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> >> wrote: >> >>> An update: as of 871d658c9ceb, the flag is now available, if folks need >>> to use it. >>> >>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> >>> wrote: >>> >>>> Hello all, >>>> >>>> TL;DR; if you used FileCheck --chec...

...heck/FileCheck.cpp ninja check-llvm # or check-clang ... >>> >>> >>>> >>>> >>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> wrote: >>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks need to use it. >>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> wrote: >>>>>> >>>>>> Hello all, >>>>>> >>>>>> TL;DR; if...

...gt; >> >>> >> >>>> >> >>>> >> >>>> >> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> >> wrote: >> >>>>> >> >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks >> need to use it. >> >>>>> >> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> >> wrote: >> >>>>>> >> >>>>>> Hello all, >&...

...gt; >>>> >>>> >>>> >>>> >>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> >>>> wrote: >>>> >>>>> >>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if >>>> folks need to use it. >>>> >>>>> >>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < >>>> mtrofin at google.com> wrote: >>>> >>>>>> >>&...

...as added automatically, not vetted/intentionally added by a human. Something like "// FIXME: Verify that unused prefixes are used intentionally" or the like. > > > On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> wrote: > >> An update: as of 871d658c9ceb, the flag is now available, if folks need >> to use it. >> >> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> >> wrote: >> >>> Hello all, >>> >>> TL;DR; if you used FileCheck --check-prefixes and you missed >&g...

...;>>>>> >>>> >>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < >>>>>> mtrofin at google.com> wrote: >>>>>> >>>>> >>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if >>>>>> folks need to use it. >>>>>> >>>>> >>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < >>>>>> mtrofin at google.com> wrote: >>>>&gt...

...hile staring at the test and not being able to see why someone would've done that intentionally. > >> >>> >>> >>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> >>> wrote: >>> >>>> An update: as of 871d658c9ceb, the flag is now available, if folks need >>>> to use it. >>>> >>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> >>>> wrote: >>>> >>>>> Hello all, >>>>> >>>>> TL;...

...t;>>> >>>> > >>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < > mtrofin at google.com> wrote: > >>>>>>> >>>>> > >>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if > folks need to use it. > >>>>>>> >>>>> > >>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < > mtrofin at google.com> wrote: > >>>>>>> >&gt...

...t; > > > > >>> > >>> > >>>> > >>>> > >>>> > >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> > wrote: > >>>>> > >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks > need to use it. > >>>>> > >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> > wrote: > >>>>>> > >>>>>> Hello all, > >>>>>>...

...t;> >>>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < >>>>>>>> mtrofin at google.com> wrote: >>>>>>>> >>>>> >>>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if >>>>>>>> folks need to use it. >>>>>>>> >>>>> >>>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < >>>>>>>> mtrofin at google.co...

...> > >> >>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < > mtrofin at google.com> wrote: > >> >>>>>>> >>>>> > >> >>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, > if folks need to use it. > >> >>>>>>> >>>>> > >> >>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < > mtrofin at google.com> wrote: > >> >>&...

...t;>> >>>> >>> >>>> >>> >>>> >>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> >>> wrote: >>> >>>>> >>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks >>> need to use it. >>> >>>>> >>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> >>> wrote: >>> >>>>>> >>> >>>>&...

...heck/FileCheck.cpp ninja check-llvm # or check-clang ... >>> >>> >>>> >>>> >>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> wrote: >>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks need to use it. >>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> wrote: >>>>>> >>>>>> Hello all, >>>>>> >>>>>> TL;DR; if...

...>>>> >>>>> >>>> >>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < >>>>> mtrofin at google.com> wrote: >>>>> >>>>> >>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if >>>>> folks need to use it. >>>>> >>>>> >>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < >>>>> mtrofin at google.com> wrote: >>>>> >>>&g...

...>>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < > mtrofin at google.com> wrote: > >> >> >>>>>>> >>>>> > >> >> >>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now > available, if folks need to use it. > >> >> >>>>>>> >>>>> > >> >> >>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < > mtrofin at google.com> wrote: >...

...t;> >>>>>>> >>>> >>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> wrote: >>>>>>> >>>>> >>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks need to use it. >>>>>>> >>>>> >>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> wrote: >>>>>>> >>>>>> >>...

...;> >>>> >>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin < >>>>>>> mtrofin at google.com> wrote: >>>>>>> >>>>> >>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if >>>>>>> folks need to use it. >>>>>>> >>>>> >>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin < >>>>>>> mtrofin at google.com> wrote: &gt...

...>> >>>> >> >>>>>>> >>>> On Fri, Oct 30, 2020 at 12:48 PM Mircea Trofin <mtrofin at google.com> wrote: >> >>>>>>> >>>>> >> >>>>>>> >>>>> An update: as of 871d658c9ceb, the flag is now available, if folks need to use it. >> >>>>>>> >>>>> >> >>>>>>> >>>>> On Thu, Oct 29, 2020 at 10:28 AM Mircea Trofin <mtrofin at google.com> wrote: >> >>>>>>> >&g...

Hello all, TL;DR; if you used FileCheck --check-prefixes and you missed (misspelled, for instance) one of the prefixes in your test, FileCheck silently ignores that and the test passes. 1579 tests have this property. *The details* *=========* Please refer to https://reviews.llvm.org/D90281 and the discussion there for more details (make sure you open "older changes" for full context)