search for: 8365aae

...nice to make the warning actionable, but there is not a lot that end users can do since fstrim is such a complex topic interacting with all filesystem and storage layers. --- v2v/v2v.ml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index e221f29..8365aae 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -397,11 +397,7 @@ and do_fstrim g inspect = if mounted then ( try g#fstrim "/" with G.Error msg -> - (* Only emit this warning when debugging, because otherwise - * it causes distress (RHBZ#1168144)...

...users can do since fstrim is such a complex topic > > interacting with all filesystem and storage layers. > > --- > > v2v/v2v.ml | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > > index e221f29..8365aae 100644 > > --- a/v2v/v2v.ml > > +++ b/v2v/v2v.ml > > @@ -397,11 +397,7 @@ and do_fstrim g inspect = > > if mounted then ( > > try g#fstrim "/" > > with G.Error msg -> > > - (* Only emit this warning when debugg...

...for fstrim to work. I'm not actually sure if this is true, but it's what virt-sparsify --in-place does, and that utility has been tested a lot more in regards to trimming. --- v2v/v2v.ml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 8365aae..8ae3dec 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -393,7 +393,10 @@ and do_fstrim g inspect = List.iter ( fun dev -> g#umount_all (); - let mounted = try g#mount dev "/"; true with G.Error _ -> false in + let mounted = + try g#mount_options "d...

...t there is not a > lot that end users can do since fstrim is such a complex topic > interacting with all filesystem and storage layers. > --- > v2v/v2v.ml | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > index e221f29..8365aae 100644 > --- a/v2v/v2v.ml > +++ b/v2v/v2v.ml > @@ -397,11 +397,7 @@ and do_fstrim g inspect = > if mounted then ( > try g#fstrim "/" > with G.Error msg -> > - (* Only emit this warning when debugging, because otherwise > -...

...complex topic > > > interacting with all filesystem and storage layers. > > > --- > > > v2v/v2v.ml | 6 +----- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > diff --git a/v2v/v2v.ml b/v2v/v2v.ml > > > index e221f29..8365aae 100644 > > > --- a/v2v/v2v.ml > > > +++ b/v2v/v2v.ml > > > @@ -397,11 +397,7 @@ and do_fstrim g inspect = > > > if mounted then ( > > > try g#fstrim "/" > > > with G.Error msg -> > > > - (*...