search for: 8241a1e466cd

...: Matthew Rosato <mjrosato at linux.vnet.ibm.com> >> Signed-off-by: Jason Wang <jasowang at redhat.com> >> --- > Now that vhost_poll_stop happens on data path > a lot, I'd say > if (poll->wqh) > there should be unlikely(). It has been there since 8241a1e466cd ("vhost_net: stop polling socket during rx processing"). So it will be used for rx path too which unlikely() does not work as well as the case in tx. > > >> drivers/vhost/net.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >>...

...: Matthew Rosato <mjrosato at linux.vnet.ibm.com> >> Signed-off-by: Jason Wang <jasowang at redhat.com> >> --- > Now that vhost_poll_stop happens on data path > a lot, I'd say > if (poll->wqh) > there should be unlikely(). It has been there since 8241a1e466cd ("vhost_net: stop polling socket during rx processing"). So it will be used for rx path too which unlikely() does not work as well as the case in tx. > > >> drivers/vhost/net.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >>...

...t.ibm.com> > > > Signed-off-by: Jason Wang <jasowang at redhat.com> > > > --- > > Now that vhost_poll_stop happens on data path > > a lot, I'd say > > if (poll->wqh) > > there should be unlikely(). > > It has been there since 8241a1e466cd ("vhost_net: stop polling socket during > rx processing"). So it will be used for rx path too which unlikely() does > not work as well as the case in tx. Worth testing, does not have to block this patch. > > > > > > > > drivers/vhost/net.c | 11 +++++++...

We always poll tx for socket, this is sub optimal since: - we only want to be notified when sndbuf is available - this will slightly increase the waitqueue traversing time and more important, vhost could not benefit from commit commit 9e641bdcfa4e ("net-tun: restructure tun_do_read for better sleep/wakeup efficiency") even if we've stopped rx polling during handle_rx() since

We always poll tx for socket, this is sub optimal since: - we only want to be notified when sndbuf is available - this will slightly increase the waitqueue traversing time and more important, vhost could not benefit from commit commit 9e641bdcfa4e ("net-tun: restructure tun_do_read for better sleep/wakeup efficiency") even if we've stopped rx polling during handle_rx() since