Displaying 3 results from an estimated 3 matches for "80d055b".
2012 Feb 08
0
[PATCH] Remove even more CPP hackery
Dave Yeo wrote:
> Another try
Actually there are still some issues with this patch, mainly around
your changes to incluce/FLAC/ordinals.h. This file is a public header
file and hence, your changes:
diff --git a/include/FLAC/ordinals.h b/include/FLAC/ordinals.h
index 80d055b..dc2dafc 100644
--- a/include/FLAC/ordinals.h
+++ b/include/FLAC/ordinals.h
@@ -32,10 +32,18 @@
#ifndef FLAC__ORDINALS_H
#define FLAC__ORDINALS_H
-#if !(defined(_MSC_VER) || defined(__BORLANDC__) || defined(__EMX__))
+#if HAVE_CONFIG_H
+# include <config....
2012 Feb 07
2
[PATCH] Remove even more CPP hackery
...rc/libFLAC/metadata_iterators.c | 2 +-
src/libFLAC/metadata_object.c | 2 +-
src/share/grabbag/cuesheet.c | 2 +-
src/test_libFLAC/metadata_manip.c | 2 +-
6 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/include/FLAC/ordinals.h b/include/FLAC/ordinals.h
index 80d055b..dc2dafc 100644
--- a/include/FLAC/ordinals.h
+++ b/include/FLAC/ordinals.h
@@ -32,10 +32,18 @@
#ifndef FLAC__ORDINALS_H
#define FLAC__ORDINALS_H
-#if !(defined(_MSC_VER) || defined(__BORLANDC__) || defined(__EMX__))
+#if HAVE_CONFIG_H
+# include <config.h>
+#endif
+
+#if !(defined(_MSC_V...
2012 Feb 07
5
[PATCH] Remove even more CPP hackery
On 02/07/12 12:03 am, Erik de Castro Lopo wrote:
> Dave Yeo wrote:
>
>> This commit will break OS/2's EMX 0.9d library (GCC 2.8.1) which has been
>> been replaced by klibc. Considering the age of EMX and lack of testing
>> and that klibc contains so many improvements I think this is exceptable.
>
> Sorry Dave, I can't do that. Or rather sorry, the patch