Displaying 3 results from an estimated 3 matches for "80cols".
2014 Sep 14
4
[PATCH 1/2] virtio-gpu/2d: add hardware spec include file
On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > @@ -0,0 +1,158 @@
> > > +#ifndef VIRTGPU_HW_H
> > > +#define VIRTGPU_HW_H
> >
> > Non-trivial file, deserves a copyright and license notice.
>
> Added.
Pls remember to make it consistent with other virtio headers,
which are 3-clause BSD, prefixed with this reminder:
2014 Sep 14
4
[PATCH 1/2] virtio-gpu/2d: add hardware spec include file
On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > @@ -0,0 +1,158 @@
> > > +#ifndef VIRTGPU_HW_H
> > > +#define VIRTGPU_HW_H
> >
> > Non-trivial file, deserves a copyright and license notice.
>
> Added.
Pls remember to make it consistent with other virtio headers,
which are 3-clause BSD, prefixed with this reminder:
2014 Sep 15
0
[PATCH 1/2] virtio-gpu/2d: add hardware spec include file
...2d commands */
> > > > + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
> > >
> > > Please consider also adding:
>
> VIRTIO_GPU_ everywhere to make it consistent with other
> virtio headers?
The names are already pretty long as-is, especially considering the
80cols rule in our codestyle. I'd prefer to keep them the way they are
now.
cheers,
Gerd