Displaying 3 results from an estimated 3 matches for "7f97163".
Did you mean:
2097163
2019 Aug 13
0
[PATCH libnbd 4/6] lib: Check Closure parameter is not NULL.
This was not permitted by the API before, but would in some
circumstances work.
---
generator/generator | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/generator/generator b/generator/generator
index 7f97163..01da1c3 100755
--- a/generator/generator
+++ b/generator/generator
@@ -3664,6 +3664,16 @@ let generate_lib_api_c () =
in
List.iter (
function
+ | Closure { cbname } ->
+ let value = match errcode with
+ | Some value -> value
+ | None -> as...
2019 Aug 13
1
Re: [PATCH libnbd 4/6] lib: Check Closure parameter is not NULL.
...ug_callback to take an OClosure instead
of a Closure). Requires completion_callback to be non-NULL, but we
relax that restriction by moving to OClosure.
ACK.
Yes, the first four can be applied no matter what else we discuss.
> diff --git a/generator/generator b/generator/generator
> index 7f97163..01da1c3 100755
> --- a/generator/generator
> +++ b/generator/generator
> @@ -3664,6 +3664,16 @@ let generate_lib_api_c () =
> in
> List.iter (
> function
> + | Closure { cbname } ->
> + let value = match errcode with
> + | Some...
2019 Aug 13
12
[PATCH 0/6] Implement OClosure.
Patches 1-4 are basically uncontroversial, straightforward refactoring
and IMHO we should just push them. Possibly 1-3 should be squashed
together, but I posted them separately so they are easier to review.
Patches 5 and 6 together implement OClosure. Patch 5 adds the feature
and is simple to understand.
Patch 6 changes the Closure completion callbacks into OClosure, but
because it doesn't