search for: 7d69c9e0d177

...sions so can still access the resource. - - This is best-effort. If something fails then we carry - on and hope for the best. *) + permissions so can still access the resource. *) val error_if_no_ssh_agent : unit -> unit diff --git a/lib/utils.ml b/lib/utils.ml index 174c01b1e92f..7d69c9e0d177 100644 --- a/lib/utils.ml +++ b/lib/utils.ml @@ -149,21 +149,15 @@ let backend_is_libvirt () = let rec chown_for_libvirt_rhbz_1045069 file = let running_as_root = Unix.geteuid () = 0 in - if running_as_root && backend_is_libvirt () then ( - try - let user = Option.value ~defa...

...- > - This is best-effort. If something fails then we carry > - on and hope for the best. *) > + permissions so can still access the resource. *) > > val error_if_no_ssh_agent : unit -> unit > > diff --git a/lib/utils.ml b/lib/utils.ml > index 174c01b1e92f..7d69c9e0d177 100644 > --- a/lib/utils.ml > +++ b/lib/utils.ml > @@ -149,21 +149,15 @@ let backend_is_libvirt () = > > let rec chown_for_libvirt_rhbz_1045069 file = > let running_as_root = Unix.geteuid () = 0 in > - if running_as_root && backend_is_libvirt () then ( > -...

...ort. If something fails then we carry >> - on and hope for the best. *) >> + permissions so can still access the resource. *) >> >> val error_if_no_ssh_agent : unit -> unit >> >> diff --git a/lib/utils.ml b/lib/utils.ml >> index 174c01b1e92f..7d69c9e0d177 100644 >> --- a/lib/utils.ml >> +++ b/lib/utils.ml >> @@ -149,21 +149,15 @@ let backend_is_libvirt () = >> >> let rec chown_for_libvirt_rhbz_1045069 file = >> let running_as_root = Unix.geteuid () = 0 in >> - if running_as_root && backend_is_...

...rry > >> - on and hope for the best. *) > >> + permissions so can still access the resource. *) > >> > >> val error_if_no_ssh_agent : unit -> unit > >> > >> diff --git a/lib/utils.ml b/lib/utils.ml > >> index 174c01b1e92f..7d69c9e0d177 100644 > >> --- a/lib/utils.ml > >> +++ b/lib/utils.ml > >> @@ -149,21 +149,15 @@ let backend_is_libvirt () = > >> > >> let rec chown_for_libvirt_rhbz_1045069 file = > >> let running_as_root = Unix.geteuid () = 0 in > >> - if run...

...- on and hope for the best. *) >>>> + permissions so can still access the resource. *) >>>> >>>> val error_if_no_ssh_agent : unit -> unit >>>> >>>> diff --git a/lib/utils.ml b/lib/utils.ml >>>> index 174c01b1e92f..7d69c9e0d177 100644 >>>> --- a/lib/utils.ml >>>> +++ b/lib/utils.ml >>>> @@ -149,21 +149,15 @@ let backend_is_libvirt () = >>>> >>>> let rec chown_for_libvirt_rhbz_1045069 file = >>>> let running_as_root = Unix.geteuid () = 0 in >&...

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024 v1 was here: <https://listman.redhat.com/archives/libguestfs/2023-June/031910.html>. Make any "chown_for_libvirt_rhbz_1045069" failure a hard one; that way the user gets to see more direct and more uniform error messages (namely that we couldn't connect to libvirt). Document those connection problems, and a simple