search for: 753d990

..._h *. So no need to use internal APIs for this. > --- > customize/perl_edit-c.c | 18 ++++++------------ > customize/perl_edit.ml | 10 ++++++++-- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/customize/perl_edit-c.c b/customize/perl_edit-c.c > index 753d990..7191bef 100644 > --- a/customize/perl_edit-c.c > +++ b/customize/perl_edit-c.c > @@ -25,30 +25,24 @@ > #include <caml/alloc.h> > #include <caml/memory.h> > #include <caml/mlvalues.h> > +#include <caml/fail.h> > > #include "file-edit.h&q...

In v1 of this patch, there was the (small) possibility that 'g' might have been garbage collected while we were in the C function. Avoid this by passing 'g' to the function as well as the C pointer, so that 'g' is pinned as a garbage collector root [by CAMLparam5] so it cannot be collected while we're in the function. Rich.

...pointer method to access the underlying guestfs_h *. So no need to use internal APIs for this. --- customize/perl_edit-c.c | 12 +++--------- customize/perl_edit.ml | 5 +++-- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/customize/perl_edit-c.c b/customize/perl_edit-c.c index 753d990..dd92b5a 100644 --- a/customize/perl_edit-c.c +++ b/customize/perl_edit-c.c @@ -25,16 +25,10 @@ #include <caml/alloc.h> #include <caml/memory.h> #include <caml/mlvalues.h> +#include <caml/fail.h> #include "file-edit.h" -/** - * We try to reuse the internals...

...od to access the underlying guestfs_h *. So no need to use internal APIs for this. --- customize/perl_edit-c.c | 18 ++++++------------ customize/perl_edit.ml | 10 ++++++++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/customize/perl_edit-c.c b/customize/perl_edit-c.c index 753d990..7191bef 100644 --- a/customize/perl_edit-c.c +++ b/customize/perl_edit-c.c @@ -25,30 +25,24 @@ #include <caml/alloc.h> #include <caml/memory.h> #include <caml/mlvalues.h> +#include <caml/fail.h> #include "file-edit.h" -/** - * We try to reuse the internals...