search for: 751129e

virt-sparsify shouldn't die if sparsifying a filesystem that contains read-only LVs. https://bugzilla.redhat.com/show_bug.cgi?id=1185561 I thought about trying to make the LV writable temporarily, but I suspect that if the sysadmin has made the LV read-only, then they probably did it for a reason, so we shouldn't touch it. Rich.

...- if not (is_ignored fs) then ( + if not (is_ignored fs) && not (is_read_only_lv fs) then ( if List.mem fs zeroes then ( if not quiet then printf (f_"Zeroing %s ...\n%!") fs; diff --git a/sparsify/in_place.ml b/sparsify/in_place.ml index 751129e..268784c 100644 --- a/sparsify/in_place.ml +++ b/sparsify/in_place.ml @@ -69,9 +69,11 @@ and perform g disk format ignores machine_readable quiet zeroes = List.exists (fun fs' -> fs = g#canonical_device_name fs') ignores in + let is_read_only_lv = is_read_only_lv g in + Lis...

...then ( > + if not (is_ignored fs) && not (is_read_only_lv fs) then ( > if List.mem fs zeroes then ( > if not quiet then > printf (f_"Zeroing %s ...\n%!") fs; > diff --git a/sparsify/in_place.ml b/sparsify/in_place.ml > index 751129e..268784c 100644 > --- a/sparsify/in_place.ml > +++ b/sparsify/in_place.ml > @@ -69,9 +69,11 @@ and perform g disk format ignores machine_readable quiet zeroes = > List.exists (fun fs' -> fs = g#canonical_device_name fs') ignores > in > > + let is_read_only...