Displaying 3 results from an estimated 3 matches for "7191bef".
2016 Apr 14
1
Re: [PATCH v2] customize/perl_edit-c.c: Don't use internal APIs.
...no need to use internal APIs for this.
> ---
> customize/perl_edit-c.c | 18 ++++++------------
> customize/perl_edit.ml | 10 ++++++++--
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/customize/perl_edit-c.c b/customize/perl_edit-c.c
> index 753d990..7191bef 100644
> --- a/customize/perl_edit-c.c
> +++ b/customize/perl_edit-c.c
> @@ -25,30 +25,24 @@
> #include <caml/alloc.h>
> #include <caml/memory.h>
> #include <caml/mlvalues.h>
> +#include <caml/fail.h>
>
> #include "file-edit.h"
>...
2016 Apr 12
3
[PATCH v2] customize/perl_edit-c.c: Don't use internal APIs.
In v1 of this patch, there was the (small) possibility that 'g' might
have been garbage collected while we were in the C function.
Avoid this by passing 'g' to the function as well as the C pointer, so
that 'g' is pinned as a garbage collector root [by CAMLparam5] so it
cannot be collected while we're in the function.
Rich.
2016 Apr 12
0
[PATCH v2] customize/perl_edit-c.c: Don't use internal APIs.
...ess the underlying
guestfs_h *. So no need to use internal APIs for this.
---
customize/perl_edit-c.c | 18 ++++++------------
customize/perl_edit.ml | 10 ++++++++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/customize/perl_edit-c.c b/customize/perl_edit-c.c
index 753d990..7191bef 100644
--- a/customize/perl_edit-c.c
+++ b/customize/perl_edit-c.c
@@ -25,30 +25,24 @@
#include <caml/alloc.h>
#include <caml/memory.h>
#include <caml/mlvalues.h>
+#include <caml/fail.h>
#include "file-edit.h"
-/**
- * We try to reuse the internals of the O...