search for: 713a98d90c5e

On 2018?10?11? 15:51, Ake Koomsin wrote: > commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") > disabled the virtio tx before going to suspend to avoid a use after free. > However, after resuming, it causes the virtio_net device to lose its > network connectivity. > > To solve the issue, we need to enable tx after re...

On 2018?10?11? 18:22, ake wrote: > > On 2018?10?11? 18:44, Jason Wang wrote: >> >> On 2018?10?11? 15:51, Ake Koomsin wrote: >>> commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") >>> disabled the virtio tx before going to suspend to avoid a use after free. >>> However, after resuming, it causes the virtio_net device to lose its >>> network connectivity. >>> >>> To solve...

On 2018?10?12? 12:30, ake wrote: > > On 2018?10?11? 22:06, Jason Wang wrote: >> >> On 2018?10?11? 18:22, ake wrote: >>> On 2018?10?11? 18:44, Jason Wang wrote: >>>> On 2018?10?11? 15:51, Ake Koomsin wrote: >>>>> commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") >>>>> disabled the virtio tx before going to suspend to avoid a use after >>>>> free. >>>>> However, after resuming, it causes the virtio_net device to lose its >>>>> network conn...

...0, ake wrote: >>>> On 2018?10?11? 22:06, Jason Wang wrote: >>>>> On 2018?10?11? 18:22, ake wrote: >>>>>> On 2018?10?11? 18:44, Jason Wang wrote: >>>>>>> On 2018?10?11? 15:51, Ake Koomsin wrote: >>>>>>>> commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") >>>>>>>> disabled the virtio tx before going to suspend to avoid a use after >>>>>>>> free. >>>>>>>> However, after resuming, it causes the virtio_net device to lose i...

...ently. Elide this check for reset. The request is >> always handled from the config workqueue. No other config requests >> can be active or scheduled concurrently on vi->config. > > You need to prevent packet TX from being in progress. I had another look at this. As of commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") virtnet_freeze_down calls synchronize_net() after stopping the queues to quiesce the device before any further actions. This should suffice for virtnet_reset, too. The control path can indeed be much simpler than my initial patchset. The...

...ently. Elide this check for reset. The request is >> always handled from the config workqueue. No other config requests >> can be active or scheduled concurrently on vi->config. > > You need to prevent packet TX from being in progress. I had another look at this. As of commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") virtnet_freeze_down calls synchronize_net() after stopping the queues to quiesce the device before any further actions. This should suffice for virtnet_reset, too. The control path can indeed be much simpler than my initial patchset. The...