Displaying 13 results from an estimated 13 matches for "709bcd34e485".
2019 Dec 21
2
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...kernel.org
> Signed-off-by: Alistair Delva <adelva at google.com>
Thanks for debugging this, Alistair.
> ---
> drivers/net/virtio_net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 4d7d5434cc5d..709bcd34e485 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> u64 offloads;
> int err;
>
> + if (!vi->has_cvq)
> + return 0;
> +
Instead of...
2019 Dec 21
2
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...kernel.org
> Signed-off-by: Alistair Delva <adelva at google.com>
Thanks for debugging this, Alistair.
> ---
> drivers/net/virtio_net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 4d7d5434cc5d..709bcd34e485 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> u64 offloads;
> int err;
>
> + if (!vi->has_cvq)
> + return 0;
> +
Instead of...
2019 Dec 22
2
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...; > Thanks for debugging this, Alistair.
> >
> > > ---
> > > drivers/net/virtio_net.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > index 4d7d5434cc5d..709bcd34e485 100644
> > > --- a/drivers/net/virtio_net.c
> > > +++ b/drivers/net/virtio_net.c
> > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > u64 offloads;
> > > int err;
> > >
> > > +...
2019 Dec 22
2
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...; > Thanks for debugging this, Alistair.
> >
> > > ---
> > > drivers/net/virtio_net.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > index 4d7d5434cc5d..709bcd34e485 100644
> > > --- a/drivers/net/virtio_net.c
> > > +++ b/drivers/net/virtio_net.c
> > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > u64 offloads;
> > > int err;
> > >
> > > +...
2019 Dec 22
2
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...gt; > > > ---
> > > > > drivers/net/virtio_net.c | 3 +++
> > > > > 1 file changed, 3 insertions(+)
> > > > >
> > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > > index 4d7d5434cc5d..709bcd34e485 100644
> > > > > --- a/drivers/net/virtio_net.c
> > > > > +++ b/drivers/net/virtio_net.c
> > > > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > > > u64 offloads;
> > > > >...
2019 Dec 22
2
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...gt; > > > ---
> > > > > drivers/net/virtio_net.c | 3 +++
> > > > > 1 file changed, 3 insertions(+)
> > > > >
> > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > > index 4d7d5434cc5d..709bcd34e485 100644
> > > > > --- a/drivers/net/virtio_net.c
> > > > > +++ b/drivers/net/virtio_net.c
> > > > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > > > u64 offloads;
> > > > >...
2020 Jan 05
0
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...ion.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Alistair Delva <adelva at google.com>
> ---
> drivers/net/virtio_net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 4d7d5434cc5d..709bcd34e485 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> u64 offloads;
> int err;
>
> + if (!vi->has_cvq)
> + return 0;
> +
So should this return an error then?
&...
2019 Dec 22
0
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...ion.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Alistair Delva <adelva at google.com>
> ---
> drivers/net/virtio_net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 4d7d5434cc5d..709bcd34e485 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> u64 offloads;
> int err;
>
> + if (!vi->has_cvq)
> + return 0;
> +
Shouldn't this return failure if t...
2019 Dec 22
1
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...t; > drivers/net/virtio_net.c | 3 +++
> > > > > > > 1 file changed, 3 insertions(+)
> > > > > > >
> > > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > > > > index 4d7d5434cc5d..709bcd34e485 100644
> > > > > > > --- a/drivers/net/virtio_net.c
> > > > > > > +++ b/drivers/net/virtio_net.c
> > > > > > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > > > > > u64...
2019 Dec 22
0
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...<adelva at google.com>
>
> Thanks for debugging this, Alistair.
>
> > ---
> > drivers/net/virtio_net.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 4d7d5434cc5d..709bcd34e485 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > u64 offloads;
> > int err;
> >
> > + if (!vi->has_cvq)
> > +...
2019 Dec 22
0
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...listair.
> > >
> > > > ---
> > > > drivers/net/virtio_net.c | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > index 4d7d5434cc5d..709bcd34e485 100644
> > > > --- a/drivers/net/virtio_net.c
> > > > +++ b/drivers/net/virtio_net.c
> > > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > > u64 offloads;
> > > > int err;
> > >...
2019 Dec 22
0
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...t; > > > > > drivers/net/virtio_net.c | 3 +++
> > > > > > 1 file changed, 3 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > > > > > index 4d7d5434cc5d..709bcd34e485 100644
> > > > > > --- a/drivers/net/virtio_net.c
> > > > > > +++ b/drivers/net/virtio_net.c
> > > > > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> > > > > > u64 offloads;
> >...
2019 Dec 20
0
[PATCH net] virtio-net: Skip set_features on non-cvq devices
...-off-by: Alistair Delva <adelva at google.com>
Tested-by: Stephen Barber <smbarber at chromium.org>
> ---
> drivers/net/virtio_net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 4d7d5434cc5d..709bcd34e485 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev,
> u64 offloads;
> int err;
>
> + if (!vi->has_cvq)
> + return 0;
> +
>...