search for: 6f331b5

...s --install will now work. For enhanced security it is possible to disable the network by adding the --no-network flag. --- sysprep/main.ml | 5 +++++ sysprep/virt-sysprep.pod | 17 +++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/sysprep/main.ml b/sysprep/main.ml index 6f331b5..12fcf48 100644 --- a/sysprep/main.ml +++ b/sysprep/main.ml @@ -40,6 +40,7 @@ let main () = let files = ref [] in let libvirturi = ref "" in let mount_opts = ref "" in + let network = ref true in let operations = ref None in let format = ref "a...

This is just one possible way to fix this bug, but the simplest. Others I considered: - Keeping the network disabled by default. Options like --install wouldn't work and there would be no actionable error message telling users what to do to fix it. - Modifying virt-customize to warn/error/suggest if operations like --install were used but the network was disabled. However

Just refactoring, no change. --- sparsify/cmdline.ml | 49 +++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/sparsify/cmdline.ml b/sparsify/cmdline.ml index ce2b913..bd49e71 100644 --- a/sparsify/cmdline.ml +++ b/sparsify/cmdline.ml @@ -98,6 +98,7 @@ read the man page virt-sparsify(1). let check_tmpdir = !check_tmpdir in let

...kages"); let cmd = guest_update_command () in - do_run ~display:cmd cmd + do_run ~display:cmd ~warn_failed_no_network:true cmd | `Upload (path, dest) -> message (f_"Uploading: %s to %s") path dest; diff --git a/sysprep/main.ml b/sysprep/main.ml index 6f331b5..35a259c 100644 --- a/sysprep/main.ml +++ b/sysprep/main.ml @@ -40,6 +40,7 @@ let main () = let files = ref [] in let libvirturi = ref "" in let mount_opts = ref "" in + let network = ref false in let operations = ref None in let format = ref "...