search for: 6bb23824

> Thanks for reviewing this. I added a top comment for AddInsnClass and I fixed the violation of column numbers. Great. Looks good to me. > IMO, it wil be nice to keep it alive for performance comparisons. Given the overall performance > is rather determined by transition searches on the current state, for small DFA tables may not be a win > and it may still be the case for

Hi Anshu, Thanks for reviewing this. I added a top comment for AddInsnClass and I fixed the violation of column numbers. On 15/06/2012 21:31, Anshuman Dasgupta wrote: > Hi Ivan, > > The patch looks good to me. I have a couple of minor comments: > > +void State::AddInsnClass(unsigned InsnClass, > Add a top level comment describing the function > > + std::map<State*,

...>>>> llvm-commits at cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits >>> >>> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120625/6bb23824/attachment.html>