Displaying 2 results from an estimated 2 matches for "6a36994".
2012 Dec 07
2
[PATCH 0/1] virtio: console: regression in virtqueue_add_buf() change
...clear that virtqueue_add_buf() no longer returns > 0
on a mailing list (please CC me!), and I missed reviewing the virtio
changes, but glad that the testsuite caught this :)
Diff relative to your patch:
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 82ebe02..6a36994 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -396,6 +396,8 @@ static int add_inbuf(struct virtqueue *vq, struct port_buffer *buf)
ret = virtqueue_add_buf(vq, sg, 0, 1, buf, GFP_ATOMIC);
virtqueue_kick(vq);
+ if (!ret)
+ ret = vq->num_free;
return ret...
2012 Dec 07
2
[PATCH 0/1] virtio: console: regression in virtqueue_add_buf() change
...clear that virtqueue_add_buf() no longer returns > 0
on a mailing list (please CC me!), and I missed reviewing the virtio
changes, but glad that the testsuite caught this :)
Diff relative to your patch:
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 82ebe02..6a36994 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -396,6 +396,8 @@ static int add_inbuf(struct virtqueue *vq, struct port_buffer *buf)
ret = virtqueue_add_buf(vq, sg, 0, 1, buf, GFP_ATOMIC);
virtqueue_kick(vq);
+ if (!ret)
+ ret = vq->num_free;
return ret...