search for: 68e0bfc

...getenv ("NBDKIT_VALGRIND"); + if (s && strcmp (s, "1") == 0) { fprintf (stderr, "ext2 test skipped under valgrind.\n"); exit (77); /* Tells automake to skip the test. */ } diff --git a/tests/test-help.sh b/tests/test-help.sh index 68e0bfc..8dc0675 100755 --- a/tests/test-help.sh +++ b/tests/test-help.sh @@ -45,7 +45,8 @@ fi # However some of these tests are expected to fail. test () { - case "$1${NBDKIT_VALGRIND:+-valgrind}" in + [ "$NBDKIT_VALGRIND" = "1" ] && vg="-valgrind"...

...# Plugins written in scripting languages can't run under valgrind. ;; *) - nbdkit $p --dump-plugin + nbdkit $1 --dump-plugin ;; esac -done +} +foreach_plugin test diff --git a/tests/test-help.sh b/tests/test-help.sh index f1a988c..68e0bfc 100755 --- a/tests/test-help.sh +++ b/tests/test-help.sh @@ -31,6 +31,7 @@ # OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF # SUCH DAMAGE. +source ./functions.sh set -e output="$(nbdkit --help)" @@ -40,15 +41,11 @@ if [[ ! ( "$output" =~ dump-config )...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00147.html v2 was here: https://www.redhat.com/archives/libguestfs/2018-November/msg00152.html v3: - Use optarg != NULL as a sentinel for has_arg. - Moved some variable decls into the inner loop. - Make nbdkit wrapper depend on config.status, so if srcdir or builddir changes then we rebuild the wrapper. It

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00057.html v2: - Fix tab vs spaces in configure.ac. - To generate list of plugins, use printf instead of xargs. - Use 'source ./functions.sh' instead of 'source functions'. - functions.sh: Consistent quoting in foreach_plugin function. - functions.sh: Change the contract of start_nbdkit so it