search for: 6547d46

Hello, I have been hunting a memory-leak warning in vring_add_indirect: unreferenced object 0xffff88003d467e20 (size 32): comm "softirq", pid 0, jiffies 4295197765 (age 6.364s) hex dump (first 32 bytes): 28 19 bf 3d 00 00 00 00 0c 00 00 00 01 00 01 00 (..=............ 02 dc 51 3c 00 00 00 00 56 00 00 00 00 00 00 00 ..Q<....V....... backtrace:

Hello, I have been hunting a memory-leak warning in vring_add_indirect: unreferenced object 0xffff88003d467e20 (size 32): comm "softirq", pid 0, jiffies 4295197765 (age 6.364s) hex dump (first 32 bytes): 28 19 bf 3d 00 00 00 00 0c 00 00 00 01 00 01 00 (..=............ 02 dc 51 3c 00 00 00 00 56 00 00 00 00 00 00 00 ..Q<....V....... backtrace:

...Rusty Russell <rusty at rustcorp.com.au> > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c Yes, it does work. Tested-by: Christoph Paasch <christoph.paasch at uclouvain.be> This patch should be sent to stable. Thanks, Christoph > index 6b4a4db..6547d46 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -173,6 +173,8 @@ static inline int vring_add_indirect(struct vring_virtqueue *vq, > head = vq->free_head; > vq->vring.desc[head].flags = VRING_DESC_F_INDIRECT; > vq-...

...Rusty Russell <rusty at rustcorp.com.au> > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c Yes, it does work. Tested-by: Christoph Paasch <christoph.paasch at uclouvain.be> This patch should be sent to stable. Thanks, Christoph > index 6b4a4db..6547d46 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -173,6 +173,8 @@ static inline int vring_add_indirect(struct vring_virtqueue *vq, > head = vq->free_head; > vq->vring.desc[head].flags = VRING_DESC_F_INDIRECT; > vq-...

...in.be> Fix-suggested-by: Christoph Paasch <christoph.paasch at uclouvain.be> Typing-done-by: Rusty Russell <rusty at rustcorp.com.au> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 6b4a4db..6547d46 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -173,6 +173,8 @@ static inline int vring_add_indirect(struct vring_virtqueue *vq, head = vq->free_head; vq->vring.desc[head].flags = VRING_DESC_F_INDIRECT; vq->vring.desc[head].addr = virt_to_phys(desc);...