search for: 634246

...-------------- next part -------------- >From b3d27793f04ae44b2c11f6422a19b4422ac941cd Mon Sep 17 00:00:00 2001 From: Richard W.M. Jones <rjones at redhat.com> Date: Mon, 18 Oct 2010 12:56:54 +0100 Subject: [PATCH] parted: Don't return "loop" for non-partitioned devices (RHBZ#634246). If you ran part-get-parttype command on a device which didn't contain a partition, it used to return the string "loop". This is an internal representation that parted uses. We should instead return an error because part-get-parttype makes no sense for devices which are not partit...

...return NULL; - } - - /* lines[1] is something like: - * "/dev/sda:1953525168s:scsi:512:512:msdos:ATA Hitachi HDT72101;" - */ - char *r = get_table_field (lines[1], 5); - if (r == NULL) { - return NULL; - } - - /* If "loop" return an error (RHBZ#634246). */ - if (STREQ (r, "loop")) { - free (r); - reply_with_error ("not a partitioned device"); - return NULL; - } - - return r; + CLEANUP_FREE_STRING_LIST char **lines = split_lines (out); + if (!lines) + return NULL; + + if (lines[0] == NULL || STRNE...

...- 638899 /dev/mapper paths should not be returned from C inspection APIs - 636918 Updates to Spanish translation - 636061 [abrt] guestfish-1.2.11-1.fc12: malloc_consolidate: Process /usr/bin/guestfish was killed by signal 11 (SIGSEGV) - 635969 glob echo mkfs ext2 /dev/vd[b-t]1 prints garbage - 634246 guestfs_part_get_parttype returns "loop" when run against a partition, LV or filesystem - 633766 virt-resize --shrink fails - 633357 Updates to Spanish translation - 633096 virt-resize calculates block device size incorrectly, doesn't work with qcow2 target - 629593 Dutch translat...

The development branch (1.5) contains some major performance improvements over the current stable branch (1.4). Furthermore nearly 3 months have passed since we branched 1.4, which is about the same time that separated 1.4 from 1.2. Thus I think around the first or second week of October we ought to start the new stable and development branches (1.6 and 1.7 resp.) At this time we should decide

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid