Displaying 2 results from an estimated 2 matches for "5ff791e".
2019 Jan 30
3
[PATCH nbdkit] xz: Do not pass can_write through to the plugin.
I'm not sure that this fix is really correct.
An alternate way I can think to fix this would be for the core server
to maintain a readonly flag for each layer (instead of just per-
server).
You could also argue that our readonly test in
server/connections.c:compute_eflags is wrong and/or that the
implementations of server/plugins.c:plugin_can_write and
server/filters.c:filter_can_write have
2019 Jan 30
0
[PATCH nbdkit] xz: Do not pass can_write through to the plugin.
...descriptor or is not open for writing.
This change also disables zero and trim because the server logic
disables those when the top backend->can_write returns false.
---
filters/xz/xz.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/filters/xz/xz.c b/filters/xz/xz.c
index 28a6a81..5ff791e 100644
--- a/filters/xz/xz.c
+++ b/filters/xz/xz.c
@@ -173,6 +173,13 @@ xz_get_size (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle)
return xzfile_get_size (h->xz);
}
+static int
+xz_can_write (struct nbdkit_next_ops *next_ops, void *nxdata,
+ void *handle)
+{
+...