search for: 5bcc692

...atch args with + | [] -> "" + | app :: xs -> app ^ quote_args xs + (* Run an external command, slurp up the output as a list of lines. *) let external_command ?(echo_cmd = true) cmd = if echo_cmd then diff --git a/mllib/common_utils.mli b/mllib/common_utils.mli index 7f288b4..5bcc692 100644 --- a/mllib/common_utils.mli +++ b/mllib/common_utils.mli @@ -239,6 +239,10 @@ val compare_version : string -> string -> int val compare_lvm2_uuids : string -> string -> int (** Compare two LVM2 UUIDs, ignoring '-' characters. *) +val stringify_args : string array -&g...

...+ | Unix.WSTOPPED i -> + error (f_"external command '%s' stopped by signal %d") + (stringify_args args) i + let shell_command ?(echo_cmd = true) cmd = if echo_cmd then debug "%s" cmd; diff --git a/mllib/common_utils.mli b/mllib/common_utils.mli index 5bcc692..1845ce4 100644 --- a/mllib/common_utils.mli +++ b/mllib/common_utils.mli @@ -249,6 +249,12 @@ val external_command : ?echo_cmd:bool -> string -> string list [echo_cmd] specifies whether output the full command on verbose mode, and it's on by default. *) +val run_command : ?ec...

Add an optional parameter to disable this behaviour, so the Curl module in v2v won't print user-sensible data (like passwords). --- builder/checksums.ml | 1 - builder/downloader.ml | 1 - builder/sigchecker.ml | 1 - mllib/common_utils.ml | 4 +++- mllib/common_utils.mli | 7 +++++-- v2v/curl.ml | 2 +- 6 files changed, 9 insertions(+), 7 deletions(-) diff --git