search for: 55a1495

file descriptors are closed when not in use Signed-off-by: Imran Zaman <imran.zaman at intel.com> --- extlinux/main.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/extlinux/main.c b/extlinux/main.c index 09740bd..55a1495 100644 --- a/extlinux/main.c +++ b/extlinux/main.c @@ -580,6 +580,7 @@ int ext2_fat_install_file(const char *path, int devfd, struct stat *rst) goto bail; } + close(fd); free(file); free(oldfile); free(c32file); @@ -778,7 +779,7 @@ static char * get_default_subvol(char *...

...cases to avoid memory leak, and ease of use in future as well Signed-off-by: Imran Zaman <imran.zaman at intel.com> --- extlinux/main.c | 44 ++++++++++++++++++++++++++++++-------------- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/extlinux/main.c b/extlinux/main.c index 55a1495..b7cdf92 100644 --- a/extlinux/main.c +++ b/extlinux/main.c @@ -1044,12 +1044,12 @@ err: } #ifndef __KLIBC__ -static const char *find_device(const char *mtab_file, dev_t dev) +static char *find_device(const char *mtab_file, dev_t dev) { struct mntent *mnt; struct stat dst; FILE...

...es to avoid memory leak, and ease of use in future as well Signed-off-by: Imran Zaman <imran.zaman at intel.com> --- extlinux/main.c | 48 ++++++++++++++++++++++++++++++++---------------- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/extlinux/main.c b/extlinux/main.c index 55a1495..7bb7443 100644 --- a/extlinux/main.c +++ b/extlinux/main.c @@ -1044,12 +1044,12 @@ err: } #ifndef __KLIBC__ -static const char *find_device(const char *mtab_file, dev_t dev) +static char *find_device(const char *mtab_file, dev_t dev) { struct mntent *mnt; struct stat dst; FILE...

...n at intel.com> Reviewed-by: Paulo Alcantara <pcacjr at zytor.com> Thanks, Paulo > --- > extlinux/main.c | 44 ++++++++++++++++++++++++++++++-------------- > 1 file changed, 30 insertions(+), 14 deletions(-) > > diff --git a/extlinux/main.c b/extlinux/main.c > index 55a1495..b7cdf92 100644 > --- a/extlinux/main.c > +++ b/extlinux/main.c > @@ -1044,12 +1044,12 @@ err: > } > > #ifndef __KLIBC__ > -static const char *find_device(const char *mtab_file, dev_t dev) > +static char *find_device(const char *mtab_file, dev_t dev) > { > st...