search for: 534,7

...is to queue delayed work, not sleep + queue work. Doing a sleep ties up one thread for 1/5 of a second, does it not? If so, as long as it's the only driver doing this, we'll be fine, but if many others copy this pattern, things will start to break, will they not? > > > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > struct virtio_balloon *vb = vdev->priv; > > > > > > unregister_oom_notifier(&vb->nb); > > > - kthread_stop(vb->thread); > > > + cancel_work_sync(&vb->wq_work)...

...is to queue delayed work, not sleep + queue work. Doing a sleep ties up one thread for 1/5 of a second, does it not? If so, as long as it's the only driver doing this, we'll be fine, but if many others copy this pattern, things will start to break, will they not? > > > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > struct virtio_balloon *vb = vdev->priv; > > > > > > unregister_oom_notifier(&vb->nb); > > > - kthread_stop(vb->thread); > > > + cancel_work_sync(&vb->wq_work)...

...st->oversample + 4 - offset - 2, N, st->oversample, interp); + interpolate_product_single(&sum, iptr, st->sinc_table + st->oversample + 4 - offset - 2, N, st->oversample, interp); #endif out[out_stride * out_sample++] = SATURATE32(PSHR32(sum, 14), 32767); @@ -534,7 +534,7 @@ static int resampler_basic_interpolate_double(SpeexResamplerState *st, spx_uint3 sum = MULT16_32_Q15(interp[0],accum[0]) + MULT16_32_Q15(interp[1],accum[1]) + MULT16_32_Q15(interp[2],accum[2]) + MULT16_32_Q15(interp[3],accum[3]); #else cubic_coef(frac, interp); - sum...

...dating it for 2.5.7. I figure at the worst, it's a nice bit of protection. It would be cool to get this put into CVS. -- Kees Cook kees@kernel.org -------------- next part -------------- --- rsync-2.4.6/main.c.foo Fri Aug 17 11:46:03 2001 +++ rsync-2.4.6/main.c Fri Aug 17 11:45:37 2001 @@ -534,6 +534,7 @@ { char *p, *p2; + if (!s || !*s) return NULL; p = strchr(s,':'); if (!p) return NULL;

...t; 60 * 2) + result = pool.undefine(:timeout => 60 * 2) end end pools.each do |pool| - result = pool.destroy - result = pool.undefine + result = pool.destroy(:timeout => 60 * 2) + result = pool.undefine(:timeout => 60 * 2) end end @@ -534,7 +534,7 @@ class TaskOmatic dest_uri = "qemu+tcp://" + dest_node.hostname + "/system" @logger.debug("Migrating from #{src_uri} to #{dest_uri}") - result = vm.migrate(dest_uri, Libvirt::Domain::MIGRATE_LIVE, '', '', 0, :timeout =&gt...

...if (IS_ERR(vb->thread)) { > - err = PTR_ERR(vb->thread); > - goto out_del_vqs; > - } > - > return 0; > > -out_del_vqs: > - unregister_oom_notifier(&vb->nb); > out_oom_notify: > vdev->config->del_vqs(vdev); > out_free_vb: > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > struct virtio_balloon *vb = vdev->priv; > > unregister_oom_notifier(&vb->nb); > - kthread_stop(vb->thread); > + cancel_work_sync(&vb->wq_work); OK but since job requeues itself, cancelling li...

...if (IS_ERR(vb->thread)) { > - err = PTR_ERR(vb->thread); > - goto out_del_vqs; > - } > - > return 0; > > -out_del_vqs: > - unregister_oom_notifier(&vb->nb); > out_oom_notify: > vdev->config->del_vqs(vdev); > out_free_vb: > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > struct virtio_balloon *vb = vdev->priv; > > unregister_oom_notifier(&vb->nb); > - kthread_stop(vb->thread); > + cancel_work_sync(&vb->wq_work); OK but since job requeues itself, cancelling li...

...inlock); - printk(KERN_INFO "ocfs2_dlm: Nodes in domain (\"%s\"): ", dlm->name); + printk(KERN_NOTICE "o2dlm: Nodes in domain %s: ", dlm->name); while ((node = find_next_bit(dlm->domain_map, O2NM_MAX_NODES, node + 1)) < O2NM_MAX_NODES) { @@ -534,7 +534,7 @@ static int dlm_exit_domain_handler(struct o2net_msg *msg, u32 len, void *data, node = exit_msg->node_idx; - printk(KERN_INFO "ocfs2_dlm: Node %u leaves domain %s\n", node, dlm->name); + printk(KERN_NOTICE "o2dlm: Node %u leaves domain %s\n", node, dlm-&gt...

...inted. The optional `<rate-limited level>` option instructs which severities should be rate limited. +### hap +> `= <boolean>` + +> Default: `true` + +Flag to globally enable or disable support for Hardware Assisted +Paging (HAP) + ### hap\_1gb > `= <boolean>` @@ -534,7 +542,7 @@ Paging (HAP). > Default: `true` -Flag to enable 1 GB host page table support for Hardware Assisted +Flag to enable 2 MB host page table support for Hardware Assisted Paging (HAP). ### hpetbroadcast diff -r 5af4f2ab06f3 -r e6ec5b2b717f xen/arch/x86/hvm/hvm.c --- a/xen/arch/x8...

...if the <device> in the long spec is empty, the first interface should be used, but the program busy wait for all interfaces. diff --git a/usr/kinit/ipconfig/main.c b/usr/kinit/ipconfig/main.c index 50141e5..72bfdaf 100644 --- a/usr/kinit/ipconfig/main.c +++ b/usr/kinit/ipconfig/main.c @@ -534,6 +534,7 @@ static int parse_device(struct netdev *dev, const char *ip) if (dev->name == NULL || dev->name[0] == '\0' || strcmp(dev->name, "all") == 0) { add_all_devices(dev); + bringup_first = 1; return 0...

https://bugzilla.redhat.com/show_bug.cgi?id=769680

...v) virtio_gpu_fbdev_init(vgdev); - virtio_gpu_cmd_get_display_info(vgdev); return 0; diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index 8fa6513e..c506792 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -534,6 +534,7 @@ static void virtio_gpu_cmd_get_display_info_cb(struct virtio_gpu_device *vgdev, } } + vgdev->display_info_pending = false; spin_unlock(&vgdev->display_info_lock); wake_up(&vgdev->resp_wq); @@ -558,6 +559,7 @@ int virtio_gpu_cmd_get_display_info(struct virti...

...not be afraid of too long blocking. > > Right but fill has a 1/5 second sleep on failure - *that* > is problematic for a system queue. Why so? As long as the maximum concurrently used workers are not high, 1/5 second or even a lot longer sleeps are completely fine. > > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > > struct virtio_balloon *vb = vdev->priv; > > > > unregister_oom_notifier(&vb->nb); > > - kthread_stop(vb->thread); > > + cancel_work_sync(&vb->wq_work); > > OK but since...

...2 23:36:03, Michael S. Tsirkin wrote: > On Sat, Jan 02, 2016 at 06:43:16AM -0500, Tejun Heo wrote: > > On Fri, Jan 01, 2016 at 12:18:17PM +0200, Michael S. Tsirkin wrote: > > > > My initial idea was to use a dedicated workqueue. Michael S. Tsirkin > > > > @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) > > > > struct virtio_balloon *vb = vdev->priv; > > > > > > > > unregister_oom_notifier(&vb->nb); > > > > - kthread_stop(vb->thread); > > > > + cancel_work_...

...v) virtio_gpu_fbdev_init(vgdev); - virtio_gpu_cmd_get_display_info(vgdev); return 0; diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index 8fa6513e..c506792 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -534,6 +534,7 @@ static void virtio_gpu_cmd_get_display_info_cb(struct virtio_gpu_device *vgdev, } } + vgdev->display_info_pending = false; spin_unlock(&vgdev->display_info_lock); wake_up(&vgdev->resp_wq); @@ -558,6 +559,7 @@ int virtio_gpu_cmd_get_display_info(struct virti...

...next; + break; + } + pl = pu; + pu = pu->next; + } + } + else { + ast_log(LOG_NOTICE,"Normally picking up a parked call!\n"); + while(pu) { if (pu->parkingnum == park) { if (pl) pl->next = pu->next; @@ -517,6 +534,7 @@ } pl = pu; pu = pu->next; + } } ast_pthread_mutex_unlock(&parking_lock); if (pu) { @@ -611,6 +629,8 @@ while(var) { if (!strcasecmp(var->name, "parkext")) { strncpy(parking_ext, var->value, sizeof(parking_ext) - 1); + } else if (!strcasecm...

It has been long since I have sent v3 of the balloon conversion from a kthread to a workqueue. I have gained some more experience with the APIs in the meantime. I hope that you would like the outcome. I have added one more patch that fixes a separate problem with restoring the balloon after the system freeze. I have found this when testing the conversion. Changes against v3: + rebased on

It has been long since I have sent v3 of the balloon conversion from a kthread to a workqueue. I have gained some more experience with the APIs in the meantime. I hope that you would like the outcome. I have added one more patch that fixes a separate problem with restoring the balloon after the system freeze. I have found this when testing the conversion. Changes against v3: + rebased on

...t;thread = kthread_run(balloon, vb, "vballoon"); - if (IS_ERR(vb->thread)) { - err = PTR_ERR(vb->thread); - goto out_del_vqs; - } - return 0; -out_del_vqs: - unregister_oom_notifier(&vb->nb); out_oom_notify: vdev->config->del_vqs(vdev); out_free_vb: @@ -563,7 +534,7 @@ static void virtballoon_remove(struct virtio_device *vdev) struct virtio_balloon *vb = vdev->priv; unregister_oom_notifier(&vb->nb); - kthread_stop(vb->thread); + cancel_work_sync(&vb->wq_work); remove_common(vb); kfree(vb); } @@ -574,10 +545,9 @@ static int virt...

While compiling two kernels and untarring a third, my root fs was remounted r/w and I got the following in dmesg (kernel 2.4.19-pre9): EXT3-fs error (device ide0(3,2)) in ext3_new_inode: error 28 Aborting journal on device ide0(3,2). ext3_abort called EXT3-fs abort (device ide0(3,2)): ext3_journal_start: Detected aborted journal. Remounting filesystem read-only Remounting filesystem read-only