search for: 53,8

zhengbin (2): drm/nouveau: remove set but not used variable 'pclks','width' drm/nouveau: remove set but not used variable 'mem' drivers/gpu/drm/nouveau/dispnv04/arb.c | 6 ++---- drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 ---- 2 files changed, 2 insertions(+), 8 deletions(-) -- 2.7.4

write.table with large data frames takes quite a long time > system.time({ + write.table(df, '/tmp/dftest.txt', row.names=FALSE) + }, gcFirst=TRUE) user system elapsed 97.302 1.532 98.837 A reason is because dimnames is always called, causing 'anonymous' row names to be created as character vectors. Avoiding this in src/library/utils, along the lines of Index: write.table.R =================================================================== --- write.table.R (rev...

...file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv04/arb.c > b/drivers/gpu/drm/nouveau/dispnv04/arb.c > index 3624955..9d4a2d9 100644 > --- a/drivers/gpu/drm/nouveau/dispnv04/arb.c > +++ b/drivers/gpu/drm/nouveau/dispnv04/arb.c > @@ -53,8 +53,8 @@ struct nv_sim_state { > static void > nv04_calc_arb(struct nv_fifo_info *fifo, struct nv_sim_state *arb) > { > - int pagemiss, cas, width, bpp; > - int nvclks, mclks, pclks, crtpagemiss; > + int pagemiss, cas, bpp; > + int nvclks, mclks, crtpagemiss; > int fo...

...ouveau/dispnv04/arb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/arb.c b/drivers/gpu/drm/nouveau/dispnv04/arb.c index 3624955..9d4a2d9 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/arb.c +++ b/drivers/gpu/drm/nouveau/dispnv04/arb.c @@ -53,8 +53,8 @@ struct nv_sim_state { static void nv04_calc_arb(struct nv_fifo_info *fifo, struct nv_sim_state *arb) { - int pagemiss, cas, width, bpp; - int nvclks, mclks, pclks, crtpagemiss; + int pagemiss, cas, bpp; + int nvclks, mclks, crtpagemiss; int found, mclk_extra, mclk_loop, cbs, m1, p1;...

...M +0100, Richard W.M. Jones wrote: > > This is the patch I tested which works (on top of the > patch posted): > > diff --git a/lib/canonical-name.c b/lib/canonical-name.c > index e0c7918b4..ae4def692 100644 > --- a/lib/canonical-name.c > +++ b/lib/canonical-name.c > @@ -53,8 +53,16 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) > * BitLocker-encrypted volume, so simply return the original > * name in that case. > */ > - if (ret == NULL && guestfs_last_errno (g) == EINVAL) > - ret = safe_strdup...

...r/lib/systemd/random-seed"; (* Fedora after F20? *) "/var/lib/urandom/random-seed"; (* Debian *) "/var/lib/misc/random-seed"; (* SuSE *) + "/etc/random-seed"; (* CirrOS *) ] in List.iter ( fun file -> @@ -52,6 +53,8 @@ let rec set_random_seed (g : Guestfs.guestfs) root = Some "/var/lib/urandom/random-seed" | "linux", ("opensuse"|"sles"|"suse-based") -> Some "/var/lib/misc/random-seed" + | "linux", "cir...

Sorry, just realized - I think disabling NAPI is necessary but not sufficient. There is also the issue that refill_work() could be scheduled. If refill_work() executes, it will re-enable NAPI. We'd need to cancel the vi->refill delayed work to prevent this AFAICT, and also ensure that no other function re-schedules vi->refill or re-enables NAPI (virtnet_open/close, virtnet_set_queues,

Sorry, just realized - I think disabling NAPI is necessary but not sufficient. There is also the issue that refill_work() could be scheduled. If refill_work() executes, it will re-enable NAPI. We'd need to cancel the vi->refill delayed work to prevent this AFAICT, and also ensure that no other function re-schedules vi->refill or re-enables NAPI (virtnet_open/close, virtnet_set_queues,

...\ - pushl $nr-256; \ + pushl $~(nr); \ SAVE_ALL \ movl %esp,%eax; \ call smp_/**/name; \ --- linus-2.6.orig/arch/i386/kernel/irq.c +++ linus-2.6/arch/i386/kernel/irq.c @@ -53,8 +53,8 @@ static union irq_ctx *softirq_ctx[NR_CPU */ fastcall unsigned int do_IRQ(struct pt_regs *regs) { - /* high bits used in ret_from_ code */ - int irq = regs->orig_eax & 0xff; + /* high bit used in ret_from_ code */ + int irq = ~regs->orig_eax; #...

...\ - pushl $nr-256; \ + pushl $~(nr); \ SAVE_ALL \ movl %esp,%eax; \ call smp_/**/name; \ --- linus-2.6.orig/arch/i386/kernel/irq.c +++ linus-2.6/arch/i386/kernel/irq.c @@ -53,8 +53,8 @@ static union irq_ctx *softirq_ctx[NR_CPU */ fastcall unsigned int do_IRQ(struct pt_regs *regs) { - /* high bits used in ret_from_ code */ - int irq = regs->orig_eax & 0xff; + /* high bit used in ret_from_ code */ + int irq = ~regs->orig_eax; #...

...1/17 05:34:34 christos Exp $ --- fake-getaddrinfo.c.orig Sun Jan 16 23:45:39 2000 +++ fake-getaddrinfo.c Sun Jan 16 23:47:45 2000 @@ -41,7 +41,7 @@ do { next = ai->ai_next; free(ai); - } while (ai = next); + } while ((ai = next) != NULL); } #endif /* !HAVE_FREEADDRINFO */ @@ -53,8 +53,8 @@ { struct addrinfo *ai; - if (ai = (struct addrinfo *)malloc(sizeof(struct addrinfo) + - sizeof(struct sockaddr_in))) { + if ((ai = (struct addrinfo *)malloc(sizeof(struct addrinfo) + + sizeof(struct sockaddr_in))) != NULL) { memset(ai, 0, sizeof(struct addrin...

...quot;guestfs.h" #include "guestfs-utils.h" @@ -41,6 +42,8 @@ main (int argc, char *argv[]) const char *s; guestfs_h *g; char *mem, *fmt; + char tmpfile[32]; + int tmpfilefd; /* Allow the test to be skipped. */ s = getenv ("SKIP_TEST_BIG_HEAP"); @@ -50,6 +53,8 @@ main (int argc, char *argv[]) exit (77); } + snprintf (tmpfile, sizeof tmpfile, "test-big-heap.XXXXXX"); + /* Make sure we're using > 1GB in the main process. This test won't * work on 32 bit platforms, because we can't allocate 2GB of * contiguo...

...ion 1.1 diff -u -r1.1 fake-getaddrinfo.c --- fake-getaddrinfo.c 2000/01/17 19:24:04 1.1 +++ fake-getaddrinfo.c 2000/01/18 15:16:49 @@ -41,7 +41,7 @@ do { next = ai->ai_next; free(ai); - } while (ai = next); + } while ((ai = next) != NULL); } #endif /* !HAVE_FREEADDRINFO */ @@ -53,8 +53,8 @@ { struct addrinfo *ai; - if (ai = (struct addrinfo *)malloc(sizeof(struct addrinfo) + - sizeof(struct sockaddr_in))) { + if ((ai = (struct addrinfo *)malloc(sizeof(struct addrinfo) + + sizeof(struct sockaddr_in))) != NULL) { memset(ai, 0, sizeof(struct addrin...

...char *. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> diff -r 8eff89a69521 tools/libfsimage/iso9660/fsys_iso9660.c --- a/tools/libfsimage/iso9660/fsys_iso9660.c Fri Mar 02 18:42:00 2007 -0500 +++ b/tools/libfsimage/iso9660/fsys_iso9660.c Fri Mar 02 23:59:19 2007 -0500 @@ -53,8 +53,8 @@ struct iso_inode_info { ((struct iso_inode_info *)(FSYS_BUF+sizeof(struct iso_sb_info))) #define PRIMDESC ((struct iso_primary_descriptor *)(FSYS_BUF + 2048)) #define DIRREC ((struct iso_directory_record *)(FSYS_BUF + 4096)) -#define RRCONT_BUF ((unsigned char...

On Thu, Sep 17, 2020 at 01:40:04PM +0100, Richard W.M. Jones wrote: >When guestfs_lvm_canonical_lv_name was called with a /dev/dm* or >/dev/mapper* name which was not an LV then a noisy error would be >printed. This would typically have happened with encrypted disks, and >now happens very noticably when inspecting Windows BitLocker- >encrypted guests. > >Using the modified

...isplay.h | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index b46be8a091e9..f7774cc927d8 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -53,6 +53,8 @@ #include "nouveau_fence.h" #include "nouveau_fbcon.h" +#include "nv50_display.h" + #include <subdev/bios/dp.h> /****************************************************************************** diff --git a/drivers/gpu/drm/nouveau/nv50_display.h b...

...gpu_display.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index ac758cd..fdfc711 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -53,8 +53,7 @@ static void virtio_gpu_user_framebuffer_destroy(struct drm_framebuffer *fb) struct virtio_gpu_framebuffer *virtio_gpu_fb = to_virtio_gpu_framebuffer(fb); - if (virtio_gpu_fb->obj) - drm_gem_object_unreference_unlocked(virtio_gpu_fb->obj); + drm_gem_object_unreference_unlock...

This is the patch I tested which works (on top of the patch posted): diff --git a/lib/canonical-name.c b/lib/canonical-name.c index e0c7918b4..ae4def692 100644 --- a/lib/canonical-name.c +++ b/lib/canonical-name.c @@ -53,8 +53,16 @@ guestfs_impl_canonical_device_name (guestfs_h *g, const char *device) * BitLocker-encrypted volume, so simply return the original * name in that case. */ - if (ret == NULL && guestfs_last_errno (g) == EINVAL) - ret = safe_strdup (g, device); + if (re...

...gpu_display.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index ac758cd..fdfc711 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -53,8 +53,7 @@ static void virtio_gpu_user_framebuffer_destroy(struct drm_framebuffer *fb) struct virtio_gpu_framebuffer *virtio_gpu_fb = to_virtio_gpu_framebuffer(fb); - if (virtio_gpu_fb->obj) - drm_gem_object_unreference_unlocked(virtio_gpu_fb->obj); + drm_gem_object_unreference_unlock...

...nto this the other day - this more explicit error message might save someone some head-scratching ;). --- src/nv_dma.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/nv_dma.c b/src/nv_dma.c index d2a6d00..339b4fe 100644 --- a/src/nv_dma.c +++ b/src/nv_dma.c @@ -53,8 +53,13 @@ NVInitDma(ScrnInfoPtr pScrn) ret = nouveau_object_new(device, 0, NOUVEAU_FIFO_CHANNEL_CLASS, data, size, &pNv->channel); if (ret) { - xf86DrvMsg(pScrn->scrnIndex, X_ERROR, - "Error creating GPU channel: %d\n", ret); + if (ret == -ENODEV) + xf86DrvM...