search for: 5223eb8

...the label of a filesystem, so this special case for btrfs should be added there (just like the ones done in set_label). Isn't blkid working on btrfs filesystems? From what I see, there is support for it already. > diff --git a/generator/actions.ml b/generator/actions.ml > index c328319..5223eb8 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12281,6 +12281,21 @@ corrupt data." }; > longdesc = "\ > Check or repair a btrfs filesystem offline." }; > > + { defaults with > + name = "btrfs_filesystem_get_label";...

In data martedì 6 gennaio 2015 09:30:19, Hu Tao ha scritto: > > > diff --git a/generator/actions.ml b/generator/actions.ml > > > index c328319..5223eb8 100644 > > > --- a/generator/actions.ml > > > +++ b/generator/actions.ml > > > @@ -12281,6 +12281,21 @@ corrupt data." }; > > > longdesc = "\ > > > Check or repair a btrfs filesystem offline." }; > > > > > > + {...

...-r is needed); should btrfs_filesystem_defragment do that automatically? What about the options like -f (to flush) and -c (to compress), are they options which get used often/usually, and thus worthy to be passed as optargs? > diff --git a/generator/actions.ml b/generator/actions.ml > index 5223eb8..4b24f8a 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12296,6 +12296,26 @@ Check or repair a btrfs filesystem offline." }; > longdesc = "\ > Get a btrfs filesystem's label." }; > > + { defaults with > + name = "bt...

Hi, There is one problem: btrfs_filesystem_set_label just doesnt work, giving error message: libguestfs: error: btrfs_filesystem_set_label: /: ERROR: unable to set label Bad address I'm almost sure the patch has no problem, but can't figure out what's the cause. So patch 5 is only for review. Other APIs have no problem. Regards, Hu Hu Tao (5): New API: btrfs_scrub New API:

...ot;); + ADD_ARG (argv, i, path_buf); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", path, err); + return NULL; + } + + return out; +} diff --git a/generator/actions.ml b/generator/actions.ml index c328319..5223eb8 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12281,6 +12281,21 @@ corrupt data." }; longdesc = "\ Check or repair a btrfs filesystem offline." }; + { defaults with + name = "btrfs_filesystem_get_label"; + style = RString "label",...

...> Isn't blkid working on btrfs filesystems? From what I see, there is > support for it already. Yes, blkid just works. I think this patch can be dropped. Thanks for reminding! Regards, Hu > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index c328319..5223eb8 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -12281,6 +12281,21 @@ corrupt data." }; > > longdesc = "\ > > Check or repair a btrfs filesystem offline." }; > > > > + { defaults with > > + name =...

...defragment"); + ADD_ARG (argv, i, path_buf); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", path, err); + return -1; + } + + return 0; +} diff --git a/generator/actions.ml b/generator/actions.ml index 5223eb8..4b24f8a 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12296,6 +12296,26 @@ Check or repair a btrfs filesystem offline." }; longdesc = "\ Get a btrfs filesystem's label." }; + { defaults with + name = "btrfs_filesystem_defragment"; + st...