Displaying 6 results from an estimated 6 matches for "510e8a8".
Did you mean:
510888
2019 Nov 26
6
[PATCH options v2 0/3] options: Allow multiple and default --key parameters.
v1:
https://www.redhat.com/archives/libguestfs/2019-November/msg00036.html
2019 Nov 26
0
[PATCH common v2 3/3] options: Allow default --key parameters.
...ey_store_key *key = &ks->keys[i];
- if (STRNEQ (key->device, device))
+ if (STRNEQ (key->device, "") &&
+ STRNEQ (key->device, device))
continue;
switch (key->type) {
diff --git a/options/options.h b/options/options.h
index 510e8a8..2f6bc5c 100644
--- a/options/options.h
+++ b/options/options.h
@@ -105,7 +105,10 @@ struct mp {
/* A key in the key store. */
struct key_store_key {
/* The device this key refers to. There may be multiple matching
- * devices in the list.
+ * devices in the list. It is never NULL but it...
2019 Nov 29
0
[common PATCH 1/2] options: rename key.device as key.id
...rror (EXIT_FAILURE, errno, "strdup");
/* 2: key type */
@@ -265,6 +265,6 @@ free_key_store (struct key_store *ks)
free (key->file.name);
break;
}
- free (key->device);
+ free (key->id);
}
}
diff --git a/options/options.h b/options/options.h
index 510e8a8..b83a92b 100644
--- a/options/options.h
+++ b/options/options.h
@@ -104,10 +104,12 @@ struct mp {
/* A key in the key store. */
struct key_store_key {
- /* The device this key refers to. There may be multiple matching
- * devices in the list.
+ /* An ID for the device this key refers to....
2019 Nov 26
0
[PATCH common v2 2/3] options: Allow multiple --key parameters.
...Key not found in the key store, ask the user for it. */
+ s = read_key (device);
+ if (!s)
+ error (EXIT_FAILURE, 0, _("could not read key from user"));
+ r[0] = s;
+ }
+
+ return r;
}
struct key_store *
diff --git a/options/options.h b/options/options.h
index 6fadf1e..510e8a8 100644
--- a/options/options.h
+++ b/options/options.h
@@ -104,7 +104,9 @@ struct mp {
/* A key in the key store. */
struct key_store_key {
- /* The device this key refers to. */
+ /* The device this key refers to. There may be multiple matching
+ * devices in the list.
+ */
char *dev...
2019 Nov 26
1
Re: [PATCH common v2 3/3] options: Allow default --key parameters.
...>
> - if (STRNEQ (key->device, device))
> + if (STRNEQ (key->device, "") &&
> + STRNEQ (key->device, device))
> continue;
>
> switch (key->type) {
> diff --git a/options/options.h b/options/options.h
> index 510e8a8..2f6bc5c 100644
> --- a/options/options.h
> +++ b/options/options.h
> @@ -105,7 +105,10 @@ struct mp {
> /* A key in the key store. */
> struct key_store_key {
> /* The device this key refers to. There may be multiple matching
> - * devices in the list.
> + * devic...
2019 Nov 29
8
[PATCH 0/1] Allow UUIDs for --key identifiers.
This combined patch series enables to decrypt LUKS devices on inspection
by allowing the UUID of the LUKS device with the --key syntax.
I opted for reusing the option instead of adding another one, as I think
that device names and UUIDs are different enough that can be properly
distinguished.
A test for this (patch #4) can be applied only when the patches for
common are applied, and the