search for: 4m_page_blocks

...i.e. 2GB free memory per page) free memory to host. It is not flexible. > > How about allocating the buffer according to the guest memory size (proportional)? That is, > > /* Calculates the maximum number of 4MB (equals to 1024 pages) free pages blocks that the system can have */ > 4m_page_blocks = totalram_pages / 1024; > > /* Allocating one page can hold 512 free page blocks, so calculates the number of pages that can hold those 4MB blocks. And this allocation should not exceed 1024 pages */ > pages_to_allocate = min(4m_page_blocks / 512, 1024); > > For a 2TB guests, whic...

...i.e. 2GB free memory per page) free memory to host. It is not flexible. > > How about allocating the buffer according to the guest memory size (proportional)? That is, > > /* Calculates the maximum number of 4MB (equals to 1024 pages) free pages blocks that the system can have */ > 4m_page_blocks = totalram_pages / 1024; > > /* Allocating one page can hold 512 free page blocks, so calculates the number of pages that can hold those 4MB blocks. And this allocation should not exceed 1024 pages */ > pages_to_allocate = min(4m_page_blocks / 512, 1024); > > For a 2TB guests, whic...

...t; memory to host. It is not flexible. > > > > How about allocating the buffer according to the guest memory size > > (proportional)? That is, > > > > /* Calculates the maximum number of 4MB (equals to 1024 pages) free > > pages blocks that the system can have */ 4m_page_blocks = > > totalram_pages / 1024; > > > > /* Allocating one page can hold 512 free page blocks, so calculates > > the number of pages that can hold those 4MB blocks. And this > > allocation should not exceed 1024 pages */ pages_to_allocate = > > min(4m_page_blocks / 5...

...lexible. > > > > > > How about allocating the buffer according to the guest memory size > > > (proportional)? That is, > > > > > > /* Calculates the maximum number of 4MB (equals to 1024 pages) free > > > pages blocks that the system can have */ 4m_page_blocks = > > > totalram_pages / 1024; > > > > > > /* Allocating one page can hold 512 free page blocks, so calculates > > > the number of pages that can hold those 4MB blocks. And this > > > allocation should not exceed 1024 pages */ pages_to_allocate = > &g...

On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free page hints by sending a command > to the guest via setting the VIRTIO_BALLOON_HOST_CMD_FREE_PAGE_HINT bit > of the host_cmd

On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free page hints by sending a command > to the guest via setting the VIRTIO_BALLOON_HOST_CMD_FREE_PAGE_HINT bit > of the host_cmd

...of 4MB free page blocks, i.e. 2GB free memory per page) free memory to host. It is not flexible. How about allocating the buffer according to the guest memory size (proportional)? That is, /* Calculates the maximum number of 4MB (equals to 1024 pages) free pages blocks that the system can have */ 4m_page_blocks = totalram_pages / 1024; /* Allocating one page can hold 512 free page blocks, so calculates the number of pages that can hold those 4MB blocks. And this allocation should not exceed 1024 pages */ pages_to_allocate = min(4m_page_blocks / 512, 1024); For a 2TB guests, which has 2^19 page blocks (4...

...n wrote: > > On Tue, Jun 19, 2018 at 01:06:48AM +0000, Wang, Wei W wrote: > > > On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: > > > > On Sat, Jun 16, 2018 at 01:09:44AM +0000, Wang, Wei W wrote: > > > > > Not necessarily, I think. We have min(4m_page_blocks / 512, 1024) above, > > > > so the maximum memory that can be reported is 2TB. For larger guests, e.g. > > > > 4TB, the optimization can still offer 2TB free memory (better than no > > > > optimization). > > > > > > > > Maybe it's bet...

On Tue, Jun 19, 2018 at 01:06:48AM +0000, Wang, Wei W wrote: > On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: > > On Sat, Jun 16, 2018 at 01:09:44AM +0000, Wang, Wei W wrote: > > > Not necessarily, I think. We have min(4m_page_blocks / 512, 1024) above, > > so the maximum memory that can be reported is 2TB. For larger guests, e.g. > > 4TB, the optimization can still offer 2TB free memory (better than no > > optimization). > > > > Maybe it's better, maybe it isn't. It certainly muddies the...

...gt; On Tue, Jun 19, 2018 at 01:06:48AM +0000, Wang, Wei W wrote: > > > > On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: > > > > > On Sat, Jun 16, 2018 at 01:09:44AM +0000, Wang, Wei W wrote: > > > > > > Not necessarily, I think. We have min(4m_page_blocks / 512, > > > > > > 1024) above, > > > > > so the maximum memory that can be reported is 2TB. For larger > guests, e.g. > > > > > 4TB, the optimization can still offer 2TB free memory (better > > > > > than no optimization). > >...

On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: > On Sat, Jun 16, 2018 at 01:09:44AM +0000, Wang, Wei W wrote: > > Not necessarily, I think. We have min(4m_page_blocks / 512, 1024) above, > so the maximum memory that can be reported is 2TB. For larger guests, e.g. > 4TB, the optimization can still offer 2TB free memory (better than no > optimization). > > Maybe it's better, maybe it isn't. It certainly muddies the waters even more. > I&...

...1:05 AM, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 01:06:48AM +0000, Wang, Wei W wrote: >> On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: >>> On Sat, Jun 16, 2018 at 01:09:44AM +0000, Wang, Wei W wrote: >>>> Not necessarily, I think. We have min(4m_page_blocks / 512, 1024) above, >>> so the maximum memory that can be reported is 2TB. For larger guests, e.g. >>> 4TB, the optimization can still offer 2TB free memory (better than no >>> optimization). >>> >>> Maybe it's better, maybe it isn't. It certainl...