search for: 4f303e44

...ng the spec. Note that there are no known clients in the wild that can actually perform this cross-export-name request; this was found by inspection, but I also tested it via strategic gdb breakpoints in qemu-io. I also don't see the point in hacking up libnbd to become such a client. Fixes: 4f303e44 Signed-off-by: Eric Blake <eblake@redhat.com> --- server/internal.h | 1 + server/protocol-handshake-newstyle.c | 16 +++++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/server/internal.h b/server/internal.h index e6a22f1a..97e417f9 100644 ---...

...t now that we have nbdkit_export_name(), we are better off obeying the spec. Note that there are no known clients in the wild that can actually perform this cross-export-name request; this was found by inspection. I also don't see the point in hacking up libnbd to become such a client. Fixes: 4f303e44 Signed-off-by: Eric Blake <eblake@redhat.com> --- server/internal.h | 1 + server/protocol-handshake-newstyle.c | 24 ++++++++++++++++++++++-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/server/internal.h b/server/internal.h index da4fae19..0603a747 10...

The first one is the nastiest - it is an assertion failure caused by a spec-compliant client and introduced by our security fix that was released in 1.14.1. Eric Blake (4): server: Fix regression for NBD_OPT_INFO before NBD_OPT_GO server: Fix back-to-back SET_META_CONTEXT server: Forbid NUL in export and context names server: Fix OPT_GO on different export than SET_META_CONTEXT

Since the v1 series (0/4, at [1]), I've applied patches 1 and 2, rewritten patch 3 [Forbid NUL in export and context names] into patch 4 here, patch 4 there turned into patch 6 here, and everything else here is new. [1]https://www.redhat.com/archives/libguestfs/2019-September/msg00180.html I don't know if there is a handy reusable function for checking whether a string contains valid