search for: 4cf46d8

Displaying 10 results from an estimated 10 matches for "4cf46d8".

[patch v2] virtio: console: cleanup an error message
2013 Jul 29
2
[patch v2] virtio: console: cleanup an error message
...13 [23:41:00], Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -2215,10 +2215,8 @@ static int __init init(void) > } > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL); > - if (!pdrvdata.debugfs_dir) { > - pr_warning(...
[patch v2] virtio: console: cleanup an error message
2013 Jul 29
2
[patch v2] virtio: console: cleanup an error message
...13 [23:41:00], Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -2215,10 +2215,8 @@ static int __init init(void) > } > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL); > - if (!pdrvdata.debugfs_dir) { > - pr_warning(...
[patch] virtio: console: fix error handling for debugfs_create_dir()
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Friday 19 July 2013, Dan Carpenter wrote: > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > Also my static checker doesn't like it when we print the error code, but > it's always just NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> This looks wrong. debugfs_create_dir intentionally returns non-NULL so failing to create
[patch] virtio: console: fix error handling for debugfs_create_dir()
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Friday 19 July 2013, Dan Carpenter wrote: > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > Also my static checker doesn't like it when we print the error code, but > it's always just NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> This looks wrong. debugfs_create_dir intentionally returns non-NULL so failing to create
[patch v2] virtio: console: cleanup an error message
2013 Jul 29
1
[patch v2] virtio: console: cleanup an error message
...useful. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > > --- > > > v2: completely different > > > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > > > index 1b456fe..4cf46d8 100644 > > > --- a/drivers/char/virtio_console.c > > > +++ b/drivers/char/virtio_console.c > > > @@ -2215,10 +2215,8 @@ static int __init init(void) > > > } > > > > > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NU...
[patch v2] virtio: console: cleanup an error message
2013 Jul 29
1
[patch v2] virtio: console: cleanup an error message
...useful. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > > --- > > > v2: completely different > > > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > > > index 1b456fe..4cf46d8 100644 > > > --- a/drivers/char/virtio_console.c > > > +++ b/drivers/char/virtio_console.c > > > @@ -2215,10 +2215,8 @@ static int __init init(void) > > > } > > > > > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NU...
[patch v2] virtio: console: cleanup an error message
2013 Jul 22
0
[patch v2] virtio: console: cleanup an error message
The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: completely different diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..4cf46d8 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -2215,10 +2215,8 @@ static int __init init(void) } pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL); - if (!pdrvdata.debugfs_dir) { - pr_warning("Error %ld creating debugfs dir for...
[patch v2] virtio: console: cleanup an error message
2013 Jul 29
0
[patch v2] virtio: console: cleanup an error message
...> The PTR_ERR(NULL) here is not useful. > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > --- > > v2: completely different > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > > index 1b456fe..4cf46d8 100644 > > --- a/drivers/char/virtio_console.c > > +++ b/drivers/char/virtio_console.c > > @@ -2215,10 +2215,8 @@ static int __init init(void) > > } > > > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL); > > - if (!pdrvdata...
[patch] virtio: console: fix error handling for debugfs_create_dir()
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..ad2cd6d 100644 --- a/drivers/char/virtio_console.c +++
[patch] virtio: console: fix error handling for debugfs_create_dir()
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..ad2cd6d 100644 --- a/drivers/char/virtio_console.c +++