Displaying 2 results from an estimated 2 matches for "4c92e2b1".
2019 Sep 01
0
[nbdkit PATCH 10/10] maint: Enable -Wshadow during compilation
Now that previous patches have cleaned up shadowing warnings, it's
worth preventing any further relapses.
Signed-off-by: Eric Blake <eblake at redhat.com>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 4c92e2b1..5842c6f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -90,7 +90,7 @@ AC_ARG_ENABLE([gcc-warnings],
[gcc_warnings=no]
)
if test "x$gcc_warnings" = "xyes"; then
- WARNINGS_CFLAGS="-Wall -Werror"
+ WARNINGS_CFLAGS="-Wall -Wshadow -Werror"...
2019 Sep 01
11
[nbdkit PATCH 00/10] Avoid -Wshadow
While working on can_FOO caching, at one point I got confused by
whether 'readonly' meant the global set by -r or a local passed to
.open(). A quick attempt to compile with -Wshadow found several other
confusing points; this series gets us to the point that we can add
-Wshadow to builds with --enable-gcc-warnings.
Eric Blake (10):
server: Avoid -Wshadow warnings
guestfs: Avoid