search for: 4b24f8a

...mandv (&out, &err, argv); > + if (r == -1) { > + reply_with_error ("%s: %s", path, err); > + return -1; > + } > + > + return 0; > +} Isn't this alredy covered by set_label? > diff --git a/generator/actions.ml b/generator/actions.ml > index 4b24f8a..7e1f3ed 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12316,6 +12316,22 @@ Get a btrfs filesystem's label." }; > longdesc = "\ > Defragment a file or directory." }; > > + { defaults with > + name = "btrfs_filesyst...

...ded); should btrfs_filesystem_defragment do that automatically? What about the options like -f (to flush) and -c (to compress), are they options which get used often/usually, and thus worthy to be passed as optargs? > diff --git a/generator/actions.ml b/generator/actions.ml > index 5223eb8..4b24f8a 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12296,6 +12296,26 @@ Check or repair a btrfs filesystem offline." }; > longdesc = "\ > Get a btrfs filesystem's label." }; > > + { defaults with > + name = "btrfs_files...

Hi, There is one problem: btrfs_filesystem_set_label just doesnt work, giving error message: libguestfs: error: btrfs_filesystem_set_label: /: ERROR: unable to set label Bad address I'm almost sure the patch has no problem, but can't figure out what's the cause. So patch 5 is only for review. Other APIs have no problem. Regards, Hu Hu Tao (5): New API: btrfs_scrub New API:

...(argv, i, path_buf); + ADD_ARG (argv, i, label); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", path, err); + return -1; + } + + return 0; +} diff --git a/generator/actions.ml b/generator/actions.ml index 4b24f8a..7e1f3ed 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12316,6 +12316,22 @@ Get a btrfs filesystem's label." }; longdesc = "\ Defragment a file or directory." }; + { defaults with + name = "btrfs_filesystem_set_label"; + style = RErr, [...

...t"); + ADD_ARG (argv, i, path_buf); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", path, err); + return -1; + } + + return 0; +} diff --git a/generator/actions.ml b/generator/actions.ml index 5223eb8..4b24f8a 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12296,6 +12296,26 @@ Check or repair a btrfs filesystem offline." }; longdesc = "\ Get a btrfs filesystem's label." }; + { defaults with + name = "btrfs_filesystem_defragment"; + style = REr...

...{ > > + reply_with_error ("%s: %s", path, err); > > + return -1; > > + } > > + > > + return 0; > > +} > > Isn't this alredy covered by set_label? > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index 4b24f8a..7e1f3ed 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -12316,6 +12316,22 @@ Get a btrfs filesystem's label." }; > > longdesc = "\ > > Defragment a file or directory." }; > > > > + { defaults with &g...