search for: 4941d472bf95b

We try to disable NAPI to prevent a single XDP TX queue being used by multiple cpus. But we don't check if device is up (NAPI is enabled), this could result stall because of infinite wait in napi_disable(). Fixing this by checking device state through netif_running() before. Fixes: 4941d472bf95b ("virtio-net: do not reset during XDP set") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9bb9e56..2d54123 100644...

We try to disable NAPI to prevent a single XDP TX queue being used by multiple cpus. But we don't check if device is up (NAPI is enabled), this could result stall because of infinite wait in napi_disable(). Fixing this by checking device state through netif_running() before. Fixes: 4941d472bf95b ("virtio-net: do not reset during XDP set") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9bb9e56..2d54123 100644...

...NAPI to prevent a single XDP TX queue being used by > multiple cpus. But we don't check if device is up (NAPI is enabled), > this could result stall because of infinite wait in > napi_disable(). Fixing this by checking device state through > netif_running() before. > > Fixes: 4941d472bf95b ("virtio-net: do not reset during XDP set") > Signed-off-by: Jason Wang <jasowang at redhat.com> Yes, mis-paired NAPI enable/disable are really a pain. Probably, we can do something in the interfaces or mechanisms to make this less error prone and less fragile. Anyways, applie...