search for: 4815a43e

...nd line is not secure on shared machines. -=item B<password=-> - -Ask for the password (interactively) when nbdkit starts up. - =item B<password=+>FILENAME Read the password from the named file. This is a secure method diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index 4815a43e..54a6e019 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -240,6 +240,10 @@ vddk_config (const char *key, const char *value) return -1; } else if (strcmp (key, "password") == 0) { + if (strcmp (value, "-") == 0) { + nbdkit_error ("password...

...nbdkit_error ("setenv: %m"); + return -1; + } + } + else if (unsetenv ("LD_LIBRARY_PATH") == -1) { + nbdkit_error ("unsetenv: %m"); + return -1; + } + } + + return 0; +} diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index 4815a43e..eb865cc2 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -40,7 +40,6 @@ #include <string.h> #include <unistd.h> #include <dlfcn.h> -#include <fcntl.h> #include <libgen.h> #include <pthread.h> @@ -52,8 +51,8 @@ #include "isaligned.h&quo...

Probably needs a bit of cleanup, but seems like it is generally the right direction. One thing I've noticed is that the expect test randomly (but rarely) hangs :-( I guess something is racey but I don't know what at the moment. Rich.