Displaying 3 results from an estimated 3 matches for "4684,16".
Did you mean:
4634,16
2019 Jul 25
4
Re: [PATCH libnbd v3 1/2] lib: Implement closure lifetimes.
...r " PyGILState_STATE py_save = PyGILState_UNLOCKED;\n";
Another place where indentation looks odd, unless this email was
generated with whitespace changes ignored. (Cleaning up whitespace in a
separate patch to let THIS patch focus on the semantic changes is also
acceptable)
> @@ -4684,16 +4638,24 @@ let print_ocaml_binding (name, { args; ret }) =
> pr "\n";
> pr "static int\n";
> pr "%s_%s_wrapper " name cbname;
> - C.print_arg_list ~user_data:true cbargs;
> + C.print_arg_list ~valid_flag:true ~user...
2019 Jul 25
4
[PATCH libnbd v3 0/2] lib: Implement closure lifetimes.
I think I've addressed everything that was raised in review.
Some of the highlights:
- Callbacks should be freed reliably along all exit paths.
- There's a simple test of closure lifetimes.
- I've tried to use VALID|FREE in all the places where I'm confident
that it's safe and correct to do. There may be more places. Note
this is an optimization and shouldn't
2019 Jul 25
0
[PATCH libnbd v3 1/2] lib: Implement closure lifetimes.
...pr " caml_remove_generational_global_root (user_data);\n";
- pr " free (user_data);\n";
- pr "}\n";
- pr "\n"
- );
-
+ | Closure { cbname; cbargs } ->
let argnames =
List.map (
function
@@ -4684,16 +4638,24 @@ let print_ocaml_binding (name, { args; ret }) =
pr "\n";
pr "static int\n";
pr "%s_%s_wrapper " name cbname;
- C.print_arg_list ~user_data:true cbargs;
+ C.print_arg_list ~valid_flag:true ~user_data:true cbargs;...