search for: 3ead48f

...Note -it's only called when ./configure --enable-valgrind-daemon is used." }; +This function is used internally when testing the appliance." }; { defaults with name = "copy_attributes"; added = (1, 25, 21); diff --git a/src/conn-socket.c b/src/conn-socket.c index 3ead48f..980d7df 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -343,26 +343,6 @@ handle_log_message (guestfs_h *g, /* It's an actual log message, send it upwards. */ guestfs_int_log_message_callback (g, buf, n); -#ifdef VALGRIND_DAEMON - /* Find the canary printed by appliance/init...

Previously posted here: https://www.redhat.com/archives/libguestfs/2015-June/msg00266.html Rich.

.../appliance.c +++ b/src/appliance.c @@ -31,6 +31,7 @@ #include <sys/types.h> #include <sys/wait.h> #include <utime.h> +#include <libintl.h> #include "glthread/lock.h" #include "ignore-value.h" diff --git a/src/conn-socket.c b/src/conn-socket.c index 3ead48f..eb22b0c 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -31,6 +31,7 @@ #include <sys/socket.h> #include <sys/types.h> #include <assert.h> +#include <libintl.h> #include "guestfs.h" #include "guestfs-internal.h" diff --git a/src/copy-in-o...

--- generator/c.ml | 2 -- 1 file changed, 2 deletions(-) diff --git a/generator/c.ml b/generator/c.ml index 055b683..963cf21 100644 --- a/generator/c.ml +++ b/generator/c.ml @@ -1213,9 +1213,7 @@ and generate_client_actions hash () = #include <stdlib.h> #include <stdint.h> #include <inttypes.h> -#include <sys/types.h> #include <sys/stat.h> -#include

Currently we are unable to properly run guestfsd (the daemon) under valgrind. Attempts to run valgrind inside the appliance have not been successful (see patch 1/7). However we desperately need better valgrind coverage of the daemon, particularly because it is doing a lot of complex parsing of program output. This has been a problem for a long time. A better way to attack this problem is to

In v2: - Kernel command line parsing now moved to the appliance. - In the captive daemon test, the daemon cleanly shuts down on exit. - Add another btrfs test. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.