search for: 3chas3

getnybble() needs to return four bits at a time from every byte. During rle decode, rows are rounded to an integer number of bytes. The rle length needs to be able to hold values > 255. Signed-off-by: Chas Williams <3chas3 at gmail.com> --- core/graphics.c | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/core/graphics.c b/core/graphics.c index 1604ab4..011be4a 100644 --- a/core/graphics.c +++ b/core/graphics.c @@ -54,6 +54,9 @@ typedef struct { static ls...

>>>> getnybble() needs to return four bits at a time from every byte. During rle decode, rows are rounded to an integer number of bytes. The rle length needs to be able to hold values > 255. Signed-off-by: Chas Williams <3chas3 at gmail.com> <<<< I think this change is also already included in the patch quoted previously by Ady http://www.syslinux.org/archives/2015-July/023835.html -static inline char getnybble(void) +static inline char getnybble(uint8_t* last_nybble) { - char data = getc(fd);...

We recently have upgraded syslinux and have noticed that the boot logo code via boot.txt no longer works. I have a couple patches that get it close to working but I appear to be having trouble with color maps. Is there someone would want to help me finish figuring this out? Any interest in the patches I have to fix the rle decoder?

On Fri, 2015-08-21 at 02:18 +0300, Ady via Syslinux wrote: > > We recently have upgraded syslinux and have noticed that the boot logo > > code via boot.txt no longer works. I have a couple patches that get it > > close to working but I appear to be having trouble with color maps. Is > > there someone would want to help me finish figuring this out? > > > > Any

On Fri, 2015-08-21 at 12:33 -0700, Patrick Masotta wrote: > I think probably this patch is buggy: > > You have redefined VGAFilePtr > > -__export uint16_t *VGAFilePtr; /* Pointer into VGAFileBuf */ > +__export char *VGAFilePtr; /* Pointer into VGAFileBuf */ > > but you did not redefine i.e. > > *VGAFilePtr++ = data; > > Incrementing a

VGAFilePtr is used as a pointer into VGAFileBuf, so it should be the same type. Signed-off-by: Chas Williams <ciwillia at brocade.com> --- com32/elflink/ldlinux/msg.c | 4 ++-- core/graphics.c | 2 +- core/include/graphics.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/com32/elflink/ldlinux/msg.c b/com32/elflink/ldlinux/msg.c index 9ded33e..37cbe71

On Sat, 2015-08-22 at 00:56 -0700, Patrick Masotta wrote: > Please take a moment and see what the quoted code does; it'll save you lot of time. I wrote my versions before I knew about the other code. Unfortunately, that other code is a massive single patch and would be hard to review since it would be difficult to bisect should a bug be introduced. I will try to split the other patch