Displaying 4 results from an estimated 4 matches for "3b7eaae".
Did you mean:
0b7ea3e
2016 Dec 07
2
Re: [PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag. -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).
...m-compat-option
>
> to the `virt-v2v --machine-readable' output to indicate that this flag
> can be used.
>
> Thanks: Yaniv Kaul, Michal Skrivanek.
> ---
LGTM, just one note below.
> diff --git a/v2v/test-v2v-o-vdsm-options.sh b/v2v/test-v2v-o-vdsm-options.sh
> index 3b7eaae..1de0e17 100755
> --- a/v2v/test-v2v-o-vdsm-options.sh
> +++ b/v2v/test-v2v-o-vdsm-options.sh
> @@ -21,6 +21,7 @@
> unset CDPATH
> export LANG=C
> set -e
> +set -x
This should be left out, I guess.
Thanks,
--
Pino Toscano
2016 Dec 07
2
[PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag.
v3:
Change the flag from --vdsm-compat-11 to --vdsm-compat=1.1
Also the --machine-readable output has changed.
I have also added a test.
Rich.
2016 Dec 07
0
Re: [PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag. -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).
...-machine-readable' output to indicate that this flag
> > can be used.
> >
> > Thanks: Yaniv Kaul, Michal Skrivanek.
> > ---
>
> LGTM, just one note below.
>
> > diff --git a/v2v/test-v2v-o-vdsm-options.sh b/v2v/test-v2v-o-vdsm-options.sh
> > index 3b7eaae..1de0e17 100755
> > --- a/v2v/test-v2v-o-vdsm-options.sh
> > +++ b/v2v/test-v2v-o-vdsm-options.sh
> > @@ -21,6 +21,7 @@
> > unset CDPATH
> > export LANG=C
> > set -e
> > +set -x
>
> This should be left out, I guess.
I added it so I could see why...
[PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag. -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).
2016 Dec 07
0
[PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag. -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).
...dsm-vm-uuid *)
ovf_output : string; (* --vdsm-ovf-output *)
+ compat : string; (* --vdsm-compat=0.10|1.1 *)
}
(** Miscellaneous extra command line parameters used by VDSM. *)
diff --git a/v2v/test-v2v-o-vdsm-options.sh b/v2v/test-v2v-o-vdsm-options.sh
index 3b7eaae..1de0e17 100755
--- a/v2v/test-v2v-o-vdsm-options.sh
+++ b/v2v/test-v2v-o-vdsm-options.sh
@@ -1,6 +1,6 @@
#!/bin/bash -
# libguestfs virt-v2v test script
-# Copyright (C) 2014 Red Hat Inc.
+# Copyright (C) 2014-2016 Red Hat Inc.
#
# This program is free software; you can redistribute it and/or...