search for: 3a2b32c

...39;overlay.qcow2' appears to have a backing file. You should use copying mode sparsification for this file (see the virt-sparsify(1) manual). Thanks: Yaniv Kaul --- sparsify/in_place.ml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sparsify/in_place.ml b/sparsify/in_place.ml index 3a2b32c..669c639 100644 --- a/sparsify/in_place.ml +++ b/sparsify/in_place.ml @@ -30,6 +30,11 @@ open Cmdline module G = Guestfs let rec run disk format ignores machine_readable zeroes = + (* If the disk has a backing file, refuse to run (RHBZ#1277705). *) + if (new G.guestfs ())#disk_has_backing_fil...

This patch is easier to read if you use the 'git show -w' option. Also observe that: fun a -> ( fun () -> (* code *) ) (ie. returning a closure) is identical to: fun a () -> (* code *) Rich.

...() then g#set_verbose true; + let g = open_guestfs () in (* Note that the temporary overlay disk is always qcow2 format. *) g#add_drive ~format:"qcow2" ~readonly:false ~cachemode:"unsafe" overlaydisk; diff --git a/sparsify/in_place.ml b/sparsify/in_place.ml index 3a2b32c..6a42a11 100644 --- a/sparsify/in_place.ml +++ b/sparsify/in_place.ml @@ -31,9 +31,7 @@ module G = Guestfs let rec run disk format ignores machine_readable zeroes = (* Connect to libguestfs. *) - let g = new G.guestfs () in - if trace () then g#set_trace true; - if verbose () then g#set_ve...