search for: 38,16

I need to think about this patch series a bit more, but it does at least pass the tests. Rich.

...checks nbd_aio_is_processing > (it's false) > validation check fails > > (However the state was valid so the validation check should have > succeeded). > > Fixes commit e63a11736930c381a79a8cc2d03844cfff5db3ef. > > Thanks: Eric Blake for identifying the race condition above. > --- > @@ -2841,19 +2841,20 @@ let generate_lib_api_c () = > pr " /* We can check the state outside the handle lock because the\n"; > pr " * the state is a...

...t;; - pr " enum state state = h->state;\n"; + pr " enum state state = get_state (h);\n"; let tests = List.map ( function diff --git a/lib/connect.c b/lib/connect.c index 63d2234..b889f80 100644 --- a/lib/connect.c +++ b/lib/connect.c @@ -38,16 +38,16 @@ static int error_unless_ready (struct nbd_handle *h) { - if (nbd_internal_is_state_ready (h->state)) + if (nbd_internal_is_state_ready (get_state (h))) return 0; /* Why did it fail? */ - if (nbd_internal_is_state_closed (h->state)) { + if (nbd_internal_is_state_c...

...is moved to READY checks nbd_aio_is_processing (it's false) validation check fails (However the state was valid so the validation check should have succeeded). Fixes commit e63a11736930c381a79a8cc2d03844cfff5db3ef. Thanks: Eric Blake for identifying the race condition above. --- generator/generator | 15 ++++----- lib/connect.c | 8 ++--- lib/disconnect.c | 9 +++--- lib/internal.h | 8 +++++ lib/is-state.c | 74 ++++++++++++++++++++++++++++++++++----------- l...

...it easier to reason about the state in lockless code. --- generator/generator | 23 +++++++++++++---------- lib/connect.c | 10 +++++----- lib/disconnect.c | 8 ++++---- lib/handle.c | 2 +- lib/internal.h | 15 +++++++++++++-- lib/rw.c | 4 ++-- 6 files changed, 38 insertions(+), 24 deletions(-) diff --git a/generator/generator b/generator/generator index a3fbea9..d198007 100755 --- a/generator/generator +++ b/generator/generator @@ -2415,11 +2415,11 @@ let generate_lib_states_c () = pr " enum state next_state = %s;\n" state_enum; pr...

...xt_state (h);\n"; + pr " pthread_mutex_unlock (&h->lock);\n" + ); pr " return ret;\n"; pr "}\n"; pr "\n"; diff --git a/lib/connect.c b/lib/connect.c index 46c434f..96ed1ca 100644 --- a/lib/connect.c +++ b/lib/connect.c @@ -38,16 +38,16 @@ static int error_unless_ready (struct nbd_handle *h) { - if (nbd_internal_is_state_ready (get_state (h))) + if (nbd_internal_is_state_ready (get_next_state (h))) return 0; /* Why did it fail? */ - if (nbd_internal_is_state_closed (get_state (h))) { + if (nbd_internal_i...

...xt_state (h);\n"; + pr " pthread_mutex_unlock (&h->lock);\n" + ); pr " return ret;\n"; pr "}\n"; pr "\n"; diff --git a/lib/connect.c b/lib/connect.c index b889f80..4e3141f 100644 --- a/lib/connect.c +++ b/lib/connect.c @@ -38,16 +38,16 @@ static int error_unless_ready (struct nbd_handle *h) { - if (nbd_internal_is_state_ready (get_state (h))) + if (nbd_internal_is_state_ready (get_next_state (h))) return 0; /* Why did it fail? */ - if (nbd_internal_is_state_closed (get_state (h))) { + if (nbd_internal_i...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-June/thread.html#00055 v2 was here: https://www.redhat.com/archives/libguestfs/2019-June/thread.html#00067 v3: - Fix atomicly -> atomically in commit message. - Fix a comment. - Fix TOCTTOU: There is now an inline function generated called <name>_is_permitted_state, and this is called twice, first outside the

...cifs.upcall.8.in | 10 ++++ cifs.upcall.c | 148 ++++++++++++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 152 insertions(+), 6 deletions(-) diff --git a/cifs.upcall.8.in b/cifs.upcall.8.in index 50f79d18331d..06c6d3a02c2f 100644 --- a/cifs.upcall.8.in +++ b/cifs.upcall.8.in @@ -38,6 +38,16 @@ for a particular key type\&. While it can be run directly from the command\-line This option is deprecated and is currently ignored\&. .RE .PP +\-\-env-probe|\-e +.RS 4 +Allow cifs.upcall to do an environment probe to help find the credential +cache. This can assist the progr...

...tio.c | 13 ++++++----- include/hw/qdev-properties.h | 11 ++++++++++ include/hw/virtio/virtio-bus.h | 8 +++---- include/hw/virtio/virtio-net.h | 46 +++++++++++++++++++-------------------- include/hw/virtio/virtio-scsi.h | 6 ++--- include/hw/virtio/virtio.h | 38 ++++++++++++++++++-------------- 22 files changed, 126 insertions(+), 100 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 30492ec..60f9ff9 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -21,7 +21,7 @@ #include "virtio-9p-c...

...tio.c | 13 ++++++----- include/hw/qdev-properties.h | 11 ++++++++++ include/hw/virtio/virtio-bus.h | 8 +++---- include/hw/virtio/virtio-net.h | 46 +++++++++++++++++++-------------------- include/hw/virtio/virtio-scsi.h | 6 ++--- include/hw/virtio/virtio.h | 38 ++++++++++++++++++-------------- 22 files changed, 126 insertions(+), 100 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 30492ec..60f9ff9 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -21,7 +21,7 @@ #include "virtio-9p-c...

...hw/virtio/virtio.c | 13 +++++---- include/hw/qdev-properties.h | 12 ++++++++ include/hw/virtio/virtio-bus.h | 8 +++--- include/hw/virtio/virtio-net.h | 46 +++++++++++++++---------------- include/hw/virtio/virtio-scsi.h | 6 ++-- include/hw/virtio/virtio.h | 38 ++++++++++++++----------- 23 files changed, 184 insertions(+), 100 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 30492ec..60f9ff9 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -21,7 +21,7 @@ #include "virtio-9p-coth.h&q...

...hw/virtio/virtio.c | 13 +++++---- include/hw/qdev-properties.h | 12 ++++++++ include/hw/virtio/virtio-bus.h | 8 +++--- include/hw/virtio/virtio-net.h | 46 +++++++++++++++---------------- include/hw/virtio/virtio-scsi.h | 6 ++-- include/hw/virtio/virtio.h | 38 ++++++++++++++----------- 23 files changed, 184 insertions(+), 100 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index 30492ec..60f9ff9 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -21,7 +21,7 @@ #include "virtio-9p-coth.h&q...

...l b/v2v/output_vdsm.ml index 7cd94c0..6771daf 100644 --- a/v2v/output_vdsm.ml +++ b/v2v/output_vdsm.ml @@ -30,6 +30,7 @@ type vdsm_params = { vol_uuids : string list; vm_uuid : string; ovf_output : string; + compat : string; } class output_vdsm os vdsm_params output_alloc = @@ -37,13 +38,16 @@ object inherit output method as_options = - sprintf "-o vdsm -os %s%s%s --vdsm-vm-uuid %s --vdsm-ovf-output %s" os + sprintf "-o vdsm -os %s%s%s --vdsm-vm-uuid %s --vdsm-ovf-output %s%s" os (String.concat "" (List.map (sprintf &quot...

...gt;/dev/null; then - echo "$0: missing or broken stat command" - exit 77 -fi +requires stat --version d=cache-max-size.d rm -rf $d diff --git a/tests/test-data-7E.sh b/tests/test-data-7E.sh index e27984f..2e48e1b 100755 --- a/tests/test-data-7E.sh +++ b/tests/test-data-7E.sh @@ -38,16 +38,12 @@ source ./functions.sh set -e set -x +requires qemu-io --version + files="data-7E.out data-7E.pid data-7E.sock" rm -f $files cleanup_fn rm -f $files -# Test that qemu-io works -if ! qemu-io --help >/dev/null; then - echo "$0: missing or broken qemu-io"...

v3: Change the flag from --vdsm-compat-11 to --vdsm-compat=1.1 Also the --machine-readable output has changed. I have also added a test. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2019-January/thread.html#00198 For v2 I changed most existing prerequisite tests to use the new mechanism. I only changed simple tests. There are a few more complex tests that don't fit the “requires model” and those are not changed. I normalized qemu-io/qemu-img testing to always use the --version flag, where previously we used a mix

Small respin of the patches that I posted a few days ago. The main difference is the reordering of the series to make it do the group and grouplist manipulation first, and then the patch that makes it grab the KRB5CCNAME from the initiating process. I think the code is sound, my main question is whether we really need the command-line switch for this. Should this just be the default mode of

...; + } + + case SCHEDOP_block_on: + { + ret = do_block_on(arg); break; } diff -r fbeb0a5b7219 -r 15aea7d020cd xen/include/public/sched.h --- a/xen/include/public/sched.h Thu Mar 9 16:24:57 2006 +0000 +++ b/xen/include/public/sched.h Thu Mar 9 21:55:15 2006 -0800 @@ -38,6 +38,16 @@ #define SCHEDOP_shutdown 2 /* + * Block execution of this VCPU until an event is received for processing, + * without clearing the upcall mask; a subsequent pending event will not be + * delivered, but will still wake up the domain. This is intended for use in + * polling loops w...

Hi folks, After some time away from it, and a big rebase as a consequence, here is the updated version of paravirt_ops for x86_64, heading to inclusion. Your criticism is of course, very welcome. Have fun -- arch/x86_64/Kconfig | 11 arch/x86_64/ia32/syscall32.c | 2 arch/x86_64/kernel/Makefile | 1 arch/x86_64/kernel/apic.c | 2