search for: 36148c2bbfbe

On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: > When use_napi is set, let's enable BQLs. Note: some of the issues are > similar to wifi. It's worth considering whether something similar to > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > benefitial. I've played a similar patch several days before. The tricky part is the mode switching between napi and no napi. We should make sure when the packet is sent and trakced by BQL,? it should be consumed by BQL as well....

On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: > When use_napi is set, let's enable BQLs. Note: some of the issues are > similar to wifi. It's worth considering whether something similar to > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > benefitial. I've played a similar patch several days before. The tricky part is the mode switching between napi and no napi. We should make sure when the packet is sent and trakced by BQL,? it should be consumed by BQL as well....

...;>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>>>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>>>> similar to wifi. It's worth considering whether something similar to >>>>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>>>> benefitial. >>>>>> I've played a similar patch several days before. The tricky part is the mode >>>>>> switching between napi and no napi. We should make sure when the packe...

...;>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>>>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>>>> similar to wifi. It's worth considering whether something similar to >>>>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>>>> benefitial. >>>>>> I've played a similar patch several days before. The tricky part is the mode >>>>>> switching between napi and no napi. We should make sure when the packe...

...ason Wang wrote: >>>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>> similar to wifi. It's worth considering whether something similar to >>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>> benefitial. >>>> I've played a similar patch several days before. The tricky part is the mode >>>> switching between napi and no napi. We should make sure when the packet is >>>> se...

...06, 2018 at 04:17:36PM +0800, Jason Wang wrote: >> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>> similar to wifi. It's worth considering whether something similar to >>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>> benefitial. >> >> I've played a similar patch several days before. The tricky part is the mode >> switching between napi and no napi. We should make sure when the packet is >> sent and trakced by BQL,?...

...06, 2018 at 04:17:36PM +0800, Jason Wang wrote: >> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>> similar to wifi. It's worth considering whether something similar to >>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>> benefitial. >> >> I've played a similar patch several days before. The tricky part is the mode >> switching between napi and no napi. We should make sure when the packet is >> sent and trakced by BQL,?...

...?6:54, Michael S. Tsirkin wrote: >>>>>>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>>>>>> similar to wifi. It's worth considering whether something similar to >>>>>>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>>>>>> benefitial. >>>>>>>> I've played a similar patch several days before. The tricky part is the mode >>>>>>>> switching between napi and no napi. We should...

...?6:54, Michael S. Tsirkin wrote: >>>>>>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>>>>>> similar to wifi. It's worth considering whether something similar to >>>>>>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>>>>>> benefitial. >>>>>>>> I've played a similar patch several days before. The tricky part is the mode >>>>>>>> switching between napi and no napi. We should...

...ason Wang wrote: >>>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>> similar to wifi. It's worth considering whether something similar to >>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>> benefitial. >>>> I've played a similar patch several days before. The tricky part is the mode >>>> switching between napi and no napi. We should make sure when the packet is >>>> se...

...ason Wang wrote: >>>> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>>>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>>>> similar to wifi. It's worth considering whether something similar to >>>>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>>>> benefitial. >>>> I've played a similar patch several days before. The tricky part is the mode >>>> switching between napi and no napi. We should make sure when the packet is >>>> se...

...06, 2018 at 04:17:36PM +0800, Jason Wang wrote: >> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>> similar to wifi. It's worth considering whether something similar to >>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>> benefitial. >> >> I've played a similar patch several days before. The tricky part is the mode >> switching between napi and no napi. We should make sure when the packet is >> sent and trakced by BQL,?...

...06, 2018 at 04:17:36PM +0800, Jason Wang wrote: >> On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: >>> When use_napi is set, let's enable BQLs. Note: some of the issues are >>> similar to wifi. It's worth considering whether something similar to >>> commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be >>> benefitial. >> >> I've played a similar patch several days before. The tricky part is the mode >> switching between napi and no napi. We should make sure when the packet is >> sent and trakced by BQL,?...

Now that we have brought the virtio overhead way down with a fast packed ring implementation, we seem to be actually observing TCP drops indicative of bufferbloat. So let's try to enable TSQ. Note: it isn't clear that the default pacing is great for the virt usecase. It's worth trying to play with sk_pacing_shift_update to see what happens. For this reason, and for a more important

When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something similar to commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be benefitial. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/vir...

...chael S. Tsirkin wrote: > > > > > > > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > > > > > > > similar to wifi. It's worth considering whether something similar to > > > > > > > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > > > > > > > benefitial. > > > > > > > I've played a similar patch several days before. The tricky part is the mode > > > > > > > switching between napi and no napi. We...

...hu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > benefitial. > > > I've played a similar patch several days before. The tricky part is the mode > switching between napi and no napi. We should make sure when the packet is > sent and trakced by BQL,? it should b...

...hu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > benefitial. > > > I've played a similar patch several days before. The tricky part is the mode > switching between napi and no napi. We should make sure when the packet is > sent and trakced by BQL,? it should b...

...hu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 ??6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > benefitial. > > > I've played a similar patch several days before. The tricky part is the mode > switching between napi and no napi. We should make sure when the packet is > sent and trakced by BQL,? it should b...

...gt; > > > > > > > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > > > > > > > > > similar to wifi. It's worth considering whether something similar to > > > > > > > > > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > > > > > > > > > benefitial. > > > > > > > > > I've played a similar patch several days before. The tricky part is the mode > > > > > > > > > switching...