search for: 2d3ae84

...rives.c b/src/drives.c index ad747ab..dd508f1 100644 --- a/src/drives.c +++ b/src/drives.c @@ -34,6 +34,7 @@ #include <arpa/inet.h> #include <assert.h> #include <sys/types.h> +#include <libintl.h> #include <pcre.h> diff --git a/src/errors.c b/src/errors.c index 2d3ae84..c259884 100644 --- a/src/errors.c +++ b/src/errors.c @@ -23,6 +23,7 @@ #include <stdarg.h> #include <string.h> #include <errno.h> +#include <libintl.h> #include "c-ctype.h" diff --git a/src/filearch.c b/src/filearch.c index 29c9ba6..7b63719 100644 --- a/sr...

...18,6 +1935,7 @@ and generate_client_actions hash () = pr " }\n"; ); trace_return name style "ret_v"; + pr " RELEASE_LOCK (g);\n"; pr " return ret_v;\n"; pr "}\n\n" in diff --git a/src/errors.c b/src/errors.c index 2d3ae84..d9959b2 100644 --- a/src/errors.c +++ b/src/errors.c @@ -29,16 +29,38 @@ #include "guestfs.h" #include "guestfs-internal.h" +static const char * +unlocked_last_error (guestfs_h *g) +{ + return g->last_error; +} + const char * guestfs_last_error (guestfs_h *g) { - re...

Previous discussion here: https://www.redhat.com/archives/libguestfs/2015-June/thread.html#00048 v2: - Use a cleanup handler to release the lock. - Rebase to upstream. Note I have not fixed the problem(s) with error handling (patch 3).

--- generator/c.ml | 2 -- 1 file changed, 2 deletions(-) diff --git a/generator/c.ml b/generator/c.ml index 055b683..963cf21 100644 --- a/generator/c.ml +++ b/generator/c.ml @@ -1213,9 +1213,7 @@ and generate_client_actions hash () = #include <stdlib.h> #include <stdint.h> #include <inttypes.h> -#include <sys/types.h> #include <sys/stat.h> -#include

This patch isn't ready to go upstream. In fact, I think we might do a quick 1.30 release soon, and save this patch, and also the extensive changes proposed for the test suite[1], to after 1.30. Currently it is not safe to use the same handle from multiple threads, unless you implement your own mutexes. See: http://libguestfs.org/guestfs.3.html#multiple-handles-and-multiple-threads These

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.